qt, refactor: Optimize signal-slot connections logic #17966

1. 
   hebasto commented at 5:41 PM on January 19, 2020: member

   This PR:

   • is a follow up and based on #17937 (update: already merged)
   • implements an idea from #17937 (comment)
   • simplifies WalletFrame class interface
   • as a side effect, removes bitcoingui -> walletframe -> bitcoingui circular dependency
   • is an alternative to #17500
2. hebasto requested review from promag on Jan 19, 2020
3. hebasto closed this on Jan 19, 2020

   ---

4. hebasto reopened this on Jan 19, 2020

   ---

5. hebasto cross-referenced this on Jan 19, 2020 from issue refactor, qt: Nuke walletframe circular dependency by hebasto
6. DrahtBot added the label GUI on Jan 19, 2020
7. DrahtBot added the label Tests on Jan 19, 2020
8. 
   DrahtBot commented at 9:56 PM on January 19, 2020: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18865 (gui: Refactor WalletFrame to extend QStackView by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. Binh0103 approved
10. fanquake removed the label Tests on Jan 20, 2020
11. 
    jonasschnelli commented at 4:10 AM on January 20, 2020: contributor

    Nice cleanup. Concept ACK.

12. DrahtBot added the label Needs rebase on Jan 22, 2020
13. hebasto force-pushed on Jan 30, 2020
14. 
    hebasto commented at 6:11 PM on January 30, 2020: member

    Rebased.

15. DrahtBot removed the label Needs rebase on Jan 30, 2020
16. hebasto force-pushed on Feb 1, 2020
17. 
    hebasto commented at 9:18 AM on February 1, 2020: member

    Rebased after #17937 and #18036 have been merged.

18. DrahtBot added the label Needs rebase on Feb 4, 2020
19. hebasto force-pushed on Feb 5, 2020
20. 
    hebasto commented at 9:28 PM on February 5, 2020: member

    Rebased after #18060 has been merged.

21. DrahtBot removed the label Needs rebase on Feb 5, 2020
22. DrahtBot cross-referenced this on Feb 11, 2020 from issue gui: Drop WalletModel dependency to RecentRequestsTableModel by promag
23. DrahtBot cross-referenced this on Feb 11, 2020 from issue qt: Add privacy to the Overview page by hebasto
24. DrahtBot cross-referenced this on Mar 2, 2020 from issue wip: gui: Refactor to drop client and wallet models setters by promag
25. DrahtBot cross-referenced this on Mar 20, 2020 from issue gui: Fix segfault for loading and immediately unloading wallet by hebasto
26. DrahtBot cross-referenced this on Apr 13, 2020 from issue gui: Drop RecentRequestsTableModel dependency to WalletModel by promag
27. DrahtBot cross-referenced this on May 4, 2020 from issue gui: Refactor WalletFrame to extend QStackView by promag
28. DrahtBot cross-referenced this on May 6, 2020 from issue qt: Handle exceptions instead of crash by hebasto
29. DrahtBot added the label Needs rebase on May 29, 2020
30. qt: Move connections from WalletFrame to BitcoinGUI

    This commit does not change behavior.

    acc144528f
31. qt: Do not pass gui to WalletFrame

    This commit does not change behavior. Also it removes
    bitcoingui->walletframe->bitcoingui circular dependency.

    6258512051
32. qt: Do not pass platformStyle to WalletFrame

    This commit does not change behavior.

    dee2986f2f
33. qt: Make path to showModalOverlay slot shorter

    This commit does not change behavior.

    7d7cd84351
34. hebasto force-pushed on May 29, 2020
35. 
    hebasto commented at 11:43 AM on May 29, 2020: member

    Rebased 809fd3a6e4952671633a5c193fb5fa0f41837b29 -> 7d7cd84351b6c1637ec40f7546c1aaa16bb55199 (pr17966.04 -> pr17966.05) due to the conflict with #16432.

36. DrahtBot removed the label Needs rebase on May 29, 2020
37. 
    hebasto commented at 8:21 PM on July 6, 2020: member

    @jonasschnelli Mind reviewing this PR?

38. 
    fanquake commented at 1:01 PM on July 9, 2020: member

    There's a Concept ACK, however no subsequent review after ~6 months and this is purely a gui/qt refactor. I'm going to suggest moving this over to https://github.com/bitcoin-core/gui.

39. fanquake closed this on Jul 9, 2020

    ---

40. hebasto cross-referenced this on Jul 10, 2020 from issue refactor: Optimize signal-slot connections logic by hebasto
41. hebasto deleted the branch on Jul 10, 2020
42. bitcoin locked this on Feb 15, 2022

Contributors

hebastoDrahtBotBinh0103jonasschnellifanquake

Review Requested
promag