Some code added in #2220 no longer applies as the list of wallets is actually a combo in the toolbar.
Considering #16883, it's very unlikely the current GUI will change and follow the idea of #2220.
gui: Refactor WalletFrame to extend QStackView #18865
pull promag wants to merge 1 commits into bitcoin:master from promag:2020-05-walletframe changing 2 files +9 −20-
promag commented at 12:01 PM on May 4, 2020: member
-
gui: Refactor WalletFrame to extend QStackView f1a15185eb
- fanquake added the label GUI on May 4, 2020
-
DrahtBot commented at 4:49 PM on May 4, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15454 (Remove the automatic creation and loading of the default wallet by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on May 4, 2020 from issue qt, refactor: Optimize signal-slot connections logic by hebasto
- DrahtBot cross-referenced this on Jun 25, 2020 from issue Remove the automatic creation and loading of the default wallet by achow101
-
fanquake commented at 1:31 PM on July 9, 2020: member
I think this is another good candidate for moving to https://github.com/bitcoin-core/gui. It's Qt-only refactoring, and it hasn't received any review since being opened.
- fanquake closed this on Jul 9, 2020
- bitcoin locked this on Feb 15, 2022
