This change makes the code simpler as the client and wallet models are set in the constructor and are constant.
Based on #18064, only bbb33d6.
This does't change behavior.
wip: gui: Refactor to drop client and wallet models setters #18239
pull promag wants to merge 16 commits into bitcoin:master from promag:2020-03-drop-setmodel changing 21 files +256 −373-
promag commented at 7:56 AM on March 2, 2020: member
-
gui: Drop WalletModel dependency to RecentRequestsTableModel bbb33d6431
-
gui: Pass client and wallet models to WalletView constructor c461ea0156
-
gui: Pass wallet model to ReceiveCoinsDialog constructor a9cfc2f113
-
gui: Drop ReceiveCoinsDialog::setModel 9c73fd9147
-
gui: Pass client and wallet models to SendCoinsDialog constructor 6ab499d89a
- fanquake added the label GUI on Mar 2, 2020
- promag renamed this:
gui: Refactor to drop client and wallet models setters
wip: gui: Refactor to drop client and wallet models setters
on Mar 2, 2020 -
gui: Drop setClientModel and setModel from SendCoinsDialog 845bb528db
- promag force-pushed on Mar 2, 2020
-
DrahtBot commented at 11:04 AM on March 2, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18278 (interfaces: Describe and follow some code conventions by ryanofsky)
- #18246 (wip: gui: Drop connectSlotsByName usage by promag)
- #17966 (qt, refactor: Optimize signal-slot connections logic by hebasto)
- #17956 (gui: Disable unavailable context menu items in transactions tab by kristapsk)
- #17950 (gui: Check the strength of an encryption password by emilengler)
- #17905 (gui: Avoid redundant tx status updates by ryanofsky)
- #17877 (qt, refactor: Make enums in BitcoinUnits class scoped by hebasto)
- #17611 (gui: Make send and receive widgets extend QWidget by promag)
- #17597 (qt: Fix height of QR-less ReceiveRequestDialog by hebasto)
- #16528 (Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101)
- #16432 (qt: Add privacy to the Overview page by hebasto)
- #15768 (gui: Add close window shortcut by IPGlider)
- #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Mar 2, 2020 from issue qt, refactor: Optimize signal-slot connections logic by hebasto
- DrahtBot cross-referenced this on Mar 2, 2020 from issue gui: Make send and receive widgets extend QWidget by promag
- DrahtBot cross-referenced this on Mar 2, 2020 from issue UI external signer support (e.g. hardware wallet) by Sjors
- DrahtBot cross-referenced this on Mar 2, 2020 from issue External signer support - Wallet Box edition by Sjors
- DrahtBot cross-referenced this on Mar 2, 2020 from issue Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101
- DrahtBot cross-referenced this on Mar 2, 2020 from issue qt: Add privacy to the Overview page by hebasto
- DrahtBot cross-referenced this on Mar 2, 2020 from issue Multiprocess bitcoin by ryanofsky
- promag force-pushed on Mar 2, 2020
-
gui: Drop setClientModel from WalletView 7dd43be812
-
gui: Drop setWalletModel from WalletView 2985a9774f
-
gui: Drop setClientModel from OverviewPage b5daaca8e0
-
gui: Drop setWalletModel from OverviewPage 6c9e7bd884
-
fixups 2f6dd72005
- promag force-pushed on Mar 2, 2020
-
gui: Pass wallet model to TransactionView constructor f779a8f35d
-
gui: Drop setModel from TransactionView fd31bad0e7
- DrahtBot cross-referenced this on Mar 2, 2020 from issue wip: gui: Drop connectSlotsByName usage by promag
-
gui: Drop setModel from ReceiveRequestDialog 60e0b96d6f
-
gui: Drop setModel from SignVerifyMessageDialog f2d761e0d7
-
gui: Drop setModel from AskPassphraseDialog fab1ce81e8
- DrahtBot cross-referenced this on Mar 2, 2020 from issue gui: Avoid redundant tx status updates by ryanofsky
- DrahtBot cross-referenced this on Mar 2, 2020 from issue qt, refactor: Make BitcoinUnits::Unit a scoped enum by hebasto
- DrahtBot cross-referenced this on Mar 3, 2020 from issue gui: Disable unavailable context menu items in transactions tab by kristapsk
- DrahtBot cross-referenced this on Mar 3, 2020 from issue gui: Check the strength of an encryption password by emilengler
- DrahtBot cross-referenced this on Mar 3, 2020 from issue qt: Fix height of QR-less ReceiveRequestDialog by hebasto
- DrahtBot cross-referenced this on Mar 3, 2020 from issue gui: Add close window shortcut by IPGlider
-
hebasto commented at 11:24 AM on March 3, 2020: member
Concept ACK on including models in class invariants where appropriate.
- DrahtBot cross-referenced this on Mar 6, 2020 from issue interfaces: Describe and follow some code conventions by ryanofsky
- DrahtBot added the label Needs rebase on Mar 23, 2020
-
DrahtBot commented at 10:01 PM on March 23, 2020: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
-
fanquake commented at 12:30 PM on July 9, 2020: member
This is based on a PR that has since been closed (#18064), itself hasn't seen any review and currently needs a rebase. If it's still relevant them I'm going to suggest re-opening it in https://github.com/bitcoin-core/gui.
- fanquake closed this on Jul 9, 2020
- fanquake removed the label Needs rebase on Jul 9, 2020
- bitcoin locked this on Feb 15, 2022
Labels