Class PeerTableModel doesn't actually depend on ClientModel.
gui: Drop PeerTableModel dependency to ClientModel #18060
pull promag wants to merge 1 commits into bitcoin:master from promag:2020-02-peertablemodel changing 3 files +2 −7-
promag commented at 2:50 PM on February 3, 2020: member
-
gui: Drop PeerTableModel dependency to ClientModel ff59bcd321
-
promag commented at 2:51 PM on February 3, 2020: member
@jonasschnelli don't know how I've missed this simple change in #18036.
-
hebasto commented at 3:48 PM on February 3, 2020: member
Concept ACK.
- DrahtBot added the label GUI on Feb 3, 2020
- DrahtBot added the label Tests on Feb 3, 2020
-
DrahtBot commented at 4:24 PM on February 3, 2020: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18064 (gui: Drop WalletModel dependency to RecentRequestsTableModel by promag)
- #17966 (qt, refactor: Optimize signal-slot connections logic by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- fanquake removed the label Tests on Feb 3, 2020
- hebasto approved
-
hebasto commented at 7:06 PM on February 3, 2020: member
ACK ff59bcd3213ef61f2167c0aa60fcaf5afbc20c61, tested on Linux Mint 19.3. No changes in behavior are observed.
-
Empact commented at 8:07 PM on February 3, 2020: member
- fanquake referenced this in commit 02fafdd12c on Feb 4, 2020
- fanquake merged this on Feb 4, 2020
- fanquake closed this on Feb 4, 2020
- hebasto cross-referenced this on Feb 5, 2020 from issue qt, refactor: Optimize signal-slot connections logic by hebasto
- MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
- MarkLTZ referenced this in commit 7fdadc73fc on Apr 6, 2020
- MarkLTZ referenced this in commit 8436547baa on Apr 6, 2020
- Fabcien referenced this in commit 972b80d14b on Dec 22, 2020
- bitcoin locked this on Feb 15, 2022
