[0.12.2] Backports #7938

1. 
   MarcoFalke commented at 1:54 PM on April 25, 2016: member

   This includes the commits which were tagged with "needs backport".

2. MarcoFalke force-pushed on Apr 26, 2016
3. MarcoFalke force-pushed on Apr 26, 2016
4. MarcoFalke force-pushed on Apr 27, 2016
5. MarcoFalke force-pushed on Apr 27, 2016
6. MarcoFalke force-pushed on Apr 27, 2016
7. MarcoFalke force-pushed on Apr 27, 2016
8. MarcoFalke force-pushed on Apr 27, 2016
9. Do not download transactions during inital sync

   Github-Pull: #7164
   Rebased-From: 39a525c21fd1b34df63ab30868423b97b708ee49

   90955940d5
10. Fix and cleanup listreceivedbyX documentation

    Github-Pull: #7527
    Rebased-From: c372572595b6b19a4dd88258401d8a0046ce4469

    a9e73f71d4
11. fix spelling of advertise in src and doc

    Github-Pull: #7526
    Rebased-From: 37767fd46f673a06864df6e14d3030622b1cb2c9

    64fd0ce1d9
12. Remove spurious dollar sign. Fixes #7189.

    Github-Pull: #7189
    Rebased-From: 3d19193f14b9400f7c908a61375c330113571a38

    1c3d38bde7
13. Fix memleak in TorController [rework]

    It looks like, TorController::disconnected_cb(TorControlConnection&
    conn) gets called multiple times which results in multiple event_new().
    
    Avoid this by creating the event only once in the constructore, and
    deleting it only once in the destructor (thanks to Cory Fields for the
    idea).
    
    Replaces the fix by Jonas Schnelli in #7610, see discussion there.
    
    Github-Pull: #7637
    Rebased-From: e2195037116f47b11b66452351dba4fe606423a2

    66d5408559
14. Don't resend wallet txs that aren't in our own mempool

    Github-Pull: #7521
    Rebased-From: 5a2b1c0c8b49c5ae79946e71b9f989b33c9fcf5c

    21b2f82eb7
15. Clarify description of blockindex

    see issues:
    
    https://github.com/bitcoin-dot-org/bitcoin.org/issues/1237
    
    https://github.com/bitcoin/bitcoin/issues/7532
    
    Github-Pull: #7541
    Rebased-From: 7eef1d0dad0c48e9faefdc4fe5cfb6182edc79ab

    52c101158f
16. Remove vfReachable and modify IsReachable to only use vfLimited.

    We do not know that a class of Network is reachable, only that it is not.
    
    Github-Pull: #7553
    Rebased-From: 110b62f06992d0fb989153afff2dc3aea62a674f

    a5bc6a1bc4
17. Avoid "Unknown command" messages when receiving getaddr on outbound connections.

    Github-Pull: #7642
    Rebased-From: d84ea1a59ce3704457a162f1fd8a7353047156de

    d3ead9bcb6
18. Add curl to Gitian setup instrustions

    curl is required to fetch dependencies
    
    Github-Pull: #7658
    Rebased-From: ce41cf082c861cc8d333b811b3101d52d06f50ec

    5583a3d0a7
19. Use txid as key in mapAlreadyAskedFor

    Previously we used the CInv that would be sent to the peer announcing the
    transaction as the key, but using the txid instead allows us to decouple the
    p2p layer from the application logic (which relies on this map to avoid
    duplicate tx requests).
    
    Github-Pull: #7862
    Rebased-From: 7e91f632c70ff1848a152f24ee67a06796803943

    7e71785c40
20. Removed call to `TryCreateDirectory` from `GetDefaultDataDir` in `src/util.cpp`.

    See https://github.com/bitcoin/bitcoin/issues/7845#issuecomment-207684728.
    Also refactored `GetDefaultDataDir` function to return path for Mac in one expression.
    
    Github-Pull: #7850
    Rebased-From: 41dbc4849e0bf14eef98962b0f0bddcde0bb3014

    06c73a1751
21. Fix headers announcements edge case

    Previously we would assert that if every block in vBlockHashesToAnnounce is in
    chainActive, then the blocks to be announced must connect.  However, there are
    edge cases where this assumption could be violated (eg using invalidateblock /
    reconsiderblock), so just check for this case and revert to inv-announcement
    instead.
    
    Github-Pull: #7919
    Rebased-From: 3a99fb2cb14955f5e029d315041a093e957e6c3e

    43c14acf14
22. MarcoFalke force-pushed on Apr 27, 2016
23. MarcoFalke force-pushed on Apr 29, 2016
24. MarcoFalke force-pushed on Apr 30, 2016
25. CBase58Data::SetString: cleanse the full vector

    SetString seems to be passing the length of the wrong variable to
    memory_cleanse, resulting in the last byte of the temporary buffer not being
    securely erased.
    
    Github-Pull: #7922
    Rebased-From: 57704499be948c640c789c7fc11ed1abf8a681bd

    c3d1bc33b5
26. MarcoFalke force-pushed on Jun 4, 2016
27. MarcoFalke added the label Needs backport on Jun 4, 2016
28. MarcoFalke added this to the milestone 0.12.0 on Jun 6, 2016
29. 
    laanwj commented at 11:54 AM on June 8, 2016: member

    utACK c3d1bc3

30. laanwj removed the label Needs backport on Jun 9, 2016
31. laanwj merged this on Jun 9, 2016
32. laanwj closed this on Jun 9, 2016

    ---

33. laanwj referenced this in commit 20d00a180e on Jun 9, 2016
34. laanwj added the label Backport on Jun 9, 2016
35. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Do not download transactions during initial blockchain sync by ptschip
36. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Avoid "Unknown command" messages when receiving getaddr on outbound c… by rebroad
37. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Don't resend wallet txs that aren't in our own mempool by morcos
38. MarcoFalke cross-referenced this on Jun 9, 2016 from issue fix spelling of advertise (shows up in the debug log) by jloughry
39. MarcoFalke cross-referenced this on Jun 9, 2016 from issue [Trivial, RPC] Fix and cleanup listreceivedbyX documentation by instagibbs
40. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Clarify description of blockindex by pinheadmz
41. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Remove vfReachable and modify IsReachable to only use vfLimited. by pstratem
42. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Fix memleak in TorController [rework] by laanwj
43. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Add curl to Gitian setup instructions by btcdrak
44. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Removed call to `TryCreateDirectory` from `GetDefaultDataDir` in `src/util.cpp`. by alexreg
45. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Use txid as key in mapAlreadyAskedFor by sdaftuar
46. MarcoFalke cross-referenced this on Jun 9, 2016 from issue Fix headers announcements edge case by sdaftuar
47. MarcoFalke cross-referenced this on Jun 9, 2016 from issue CBase58Data::SetString: cleanse the full vector by kazcw
48. MarcoFalke cross-referenced this on Jun 9, 2016 from issue build: Remove spurious dollar sign. Fixes #7189. by dooglus
49. MarcoFalke deleted the branch on Jun 9, 2016
50. bitcoin locked this on Sep 8, 2021

Milestone
0.12.0