Remove vfReachable and modify IsReachable to only use vfLimited. #7553

pull pstratem wants to merge 1 commits into bitcoin:master from pstratem:2016-02-17-reachable changing 4 files +6 −16
  1. pstratem commented at 6:45 AM on February 18, 2016: contributor

    We do not know that a class of Network is reachable, only that it is not.

  2. pstratem force-pushed on Feb 18, 2016
  3. Remove vfReachable and modify IsReachable to only use vfLimited.
    We do not know that a class of Network is reachable, only that it is not.
    110b62f069
  4. laanwj added the label P2P on Feb 18, 2016
  5. laanwj commented at 10:04 AM on February 18, 2016: member

    Possibly related issue, there's some discussion there:

    • Addrman only contains seed nodes when there's no externally bound address #7098 @theuni

    Concept ACK, I don't think we need both vfLimited and vfReachable, though this will have to be carefully checked to make sure it still respects onlynet, and proxies etc. No automatic tests for any of this.

  6. pstratem commented at 10:15 AM on February 18, 2016: contributor

    @laanwj Yes this will fix that issue.

    onlynet and proxy settings are unaffected

  7. laanwj commented at 9:15 AM on February 29, 2016: member

    @theuni can you please take a look here, as you performed investigation in #7098. Do you see problems with this solution?

  8. theuni commented at 6:28 PM on March 1, 2016: member

    Concept ack, trying to balance the two was confusing. Quick code review ack as well.

  9. sipa commented at 5:20 AM on March 5, 2016: member

    Concept ACK

  10. laanwj added the label Needs backport on Mar 11, 2016
  11. laanwj merged this on Mar 11, 2016
  12. laanwj closed this on Mar 11, 2016
  13. laanwj referenced this in commit 9f14e5ad91 on Mar 11, 2016
  14. MarcoFalke referenced this in commit 328dbc2b70 on Apr 25, 2016
  15. MarcoFalke referenced this in commit a5bc6a1bc4 on Apr 27, 2016
  16. MarcoFalke commented at 10:56 AM on June 9, 2016: member

    Backported as part of #7938. Removing label 'Needs backport'.

  17. MarcoFalke removed the label Needs backport on Jun 9, 2016
  18. thokon00 referenced this in commit 85b0c2ac41 on Jun 28, 2016
  19. pinheadmz cross-referenced this on Oct 12, 2016 from issue getnetworkinfo: networks: reachable: all false, old bug from core by pinheadmz
  20. nomnombtc referenced this in commit 2bb571125c on Nov 12, 2016
  21. nomnombtc referenced this in commit 432387181e on Nov 12, 2016
  22. nomnombtc referenced this in commit 1aff96d7a8 on Nov 12, 2016
  23. nomnombtc referenced this in commit 84150a9486 on Nov 13, 2016
  24. nomnombtc referenced this in commit f30df51d66 on Nov 14, 2016
  25. sickpig referenced this in commit 98d95ffee7 on Nov 14, 2016
  26. str4d cross-referenced this on Mar 24, 2017 from issue Tor ephemeral hidden services by str4d
  27. zkbot referenced this in commit 45faa928ec on Mar 26, 2017
  28. Kokary cross-referenced this on Feb 24, 2018 from issue Starting masternodes from the masternode tab fails with "Error: invalid IP" by lowwor
  29. Empact cross-referenced this on Jan 2, 2019 from issue Tests: IsReachable is the inverse of IsLimited (DRY). Includes unit tests by mmachicao
  30. Empact cross-referenced this on Jan 10, 2019 from issue Drop IsLimited in favor of IsReachable by Empact
  31. laanwj referenced this in commit 43a79d22c1 on Jan 14, 2019
  32. dongcarl cross-referenced this on Sep 19, 2019 from issue Misleading/inaccurate `{Is,Set}Reachable` naming by dongcarl
  33. Saibato cross-referenced this on Jun 25, 2020 from issue Net: Do not re-enable Onion network when it was disabled via onlynet by ghost
  34. Saibato cross-referenced this on Jun 26, 2020 from issue torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service. by Saibato
  35. adamjonas cross-referenced this on Dec 16, 2020 from issue Addrman only contains seed nodes when there's no externally bound address by theuni
  36. Saibato cross-referenced this on Dec 17, 2020 from issue doc: tor.md updates by jonatack
  37. PastaPastaPasta referenced this in commit b8bc9e9643 on Jul 18, 2021
  38. PastaPastaPasta referenced this in commit 325aff4094 on Jul 18, 2021
  39. bitcoin locked this on Feb 15, 2022
Contributors
pstratemlaanwjtheunisipaMarcoFalke
Labels
P2P
Linked (view graph)
#7098 Addrman only contains seed nodes when there's no externally bound address#7938 [0.12.2] Backports#14425 Net: Do not re-enable Onion network when it was disabled via onlynet#15051 Tests: IsReachable is the inverse of IsLimited (DRY). Includes unit tests#15138 Drop IsLimited in favor of IsReachable#16919 Misleading/inaccurate `{Is,Set}Reachable` naming#19358 torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service.#19961 doc: tor.md updates
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC