Previously we used the CInv that would be sent to the peer announcing the transaction as the key, but using the txid instead allows us to decouple the p2p layer from the application logic.
This is a minor preparatory commit for segwit, in which the inv-type will no longer be the same for all transaction requests.
Previously we used the CInv that would be sent to the peer announcing the
transaction as the key, but using the txid instead allows us to decouple the
p2p layer from the application logic (which relies on this map to avoid
duplicate tx requests).
utACK 7e91f63
utACK 7e91f632c70ff1848a152f24ee67a06796803943
utACK 7e91f632c70ff1848a152f24ee67a06796803943
Should be tagged with "Backport 0.12.2" if this is meant for segwit.
@MarcoFalke Agreed, thanks for pointing that out.
Makes sense to me. mapAlreadyAskedFor, although the generic name could mislead, is only used for transactions, not blocks, so there is no reason to have anything but the txid in the key at all.
utACK 7e91f63
Backported as part of #7938. Removing label 'Needs backport'.