[qa] Switch to py3 #7814

Blockers:

• #7893 (figure out fix for bctest.py on precise) OR #7920 (bump to trusty)

Tested ACK https://github.com/bitcoin/bitcoin/pull/7814/commits/e5dac453d1343528760fc5a89c5c02f9368daa79

Rebased

I've been testing this on fedora linux. Would be good to know if this also works on osx and win. (If you want to test this, there is no need to compile anything. Just fetch the commit and run it through the test suite.)

Run through the short test suite on OSX 10.11, all tests passed. Can we add a line for the zeromq osx dependancy?

pip3 install pyzmq was what I needed to get it working.

I've tested both the extended and short test suite on Ubuntu 14.04. This passes. Going to test on Debian 8.4 and Ubuntu 16.04 next.

Running through the extended test suite.

Running testscript signmessages.py ...
Initializing test directory /var/folders/rb/jqqd25w926s5429rf58_zsv00000gn/T/testim6xak
JSONRPC error: Method not found
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 135, in main
    self.run_test()
  File "/Users/michael/github/bitcoin/qa/rpc-tests/signmessages.py", line 27, in run_test
    signature = self.nodes[0].signmessagewithprivkey(privKey, message)
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/coverage.py", line 49, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 139, in __call__
    raise JSONRPCException(response['error'])
Stopping nodes
Cleaning up
Failed
Traceback (most recent call last):
  File "qa/pull-tester/rpc-tests.py", line 275, in <module>
    runtests()
  File "qa/pull-tester/rpc-tests.py", line 178, in runtests
    rpcTestDir + testScripts[i] + flags, shell=True)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/subprocess.py", line 584, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/Users/michael/github/bitcoin/qa/rpc-tests/signmessages.py --srcdir /Users/michael/github/bitcoin/src  ' returned non-zero exit status 1

Looks like signmessages.py has been missed, as it also still has env/ python2

Ah yes - merging a pull that adds a new test wasn't a very good idea. Now this probably needs to be updated to include the new test, otherwise it can't be merged without breaking travis.

JSONRPC error: Method not found

Na, you just need to compile the new signmessage code.

Rebased nonetheless.

Interesting that this makes the test slower, though:

py3:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testgxs02bu5
Stopping nodes
Cleaning up
Tests successful
Duration: 2 s

py2:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testXaAvpQ
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

wait_bitcoinds() takes 2 seconds now.

Strange.

Indeed interesting; Other test still run fast with py3:

$ qa/pull-tester/rpc-tests.py disablewallet
Running testscript disablewallet.py ...
Initializing test directory /tmp/test_zgnh7e3
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

But let's not worry about it too much, this will be compensated by #7972, hopefully.

Right, well if it is two seconds on one test I don't see why it would need to be a blocker.