[qa] pull-tester: Don't mute zmq ImportError #7851

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:Mf1604-qaUnmuteError changing 1 files +62 −63
  1. MarcoFalke commented at 7:25 PM on April 9, 2016: member

    Let's consider muting exceptions bad practice. It is good to have a more verbose output, so I left this as is.

  2. [qa] pull-tester: Don't mute zmq ImportError fa05e22e91
  3. MarcoFalke force-pushed on Apr 9, 2016
  4. [qa] pull-tester: Exit early when no tests are run faa4f22342
  5. MarcoFalke force-pushed on Apr 9, 2016
  6. MarcoFalke commented at 9:47 PM on April 9, 2016: member

    Looks like I need to move some code; use https://github.com/bitcoin/bitcoin/commit/faa4f22?w=0 to check the second diff.

  7. laanwj added the label Tests on Apr 11, 2016
  8. in qa/pull-tester/rpc-tests.py:None in faa4f22342 outdated 
      66 | @@ -76,11 +67,24 @@
  67 |  if "BITCOINCLI" not in os.environ:
  68 |      os.environ["BITCOINCLI"] = buildDir + '/src/bitcoin-cli' + EXEEXT
  69 |  
  70 | -#Disable Windows tests by default
  71 |  if EXEEXT == ".exe" and "-win" not in opts:
  72 | -    print "Win tests currently disabled.  Use -win option to enable"
  73 | +    # https://github.com/bitcoin/bitcoin/commit/d52802551752140cf41f0d9a225a43e84404d3e9
    laanwj commented at 10:13 AM on April 14, 2016:

    Makes sense to refer to the discussion of the pull this was part of: #5677 (comment)

    MarcoFalke commented at 9:21 AM on April 15, 2016:

    Done

  9. laanwj commented at 10:13 AM on April 14, 2016: member

    Concept ACK

  10. MarcoFalke cross-referenced this on Apr 16, 2016 from issue [qa] Switch to py3 by MarcoFalke
  11. [qa] rpc-tests: Fix link in comment and label error msg fae1f4ebfe
  12. in qa/pull-tester/rpc-tests.py:None in fa2c9ca56a outdated 
      82 | +# python-zmq may not be installed. Handle this gracefully and with some helpful info
  83 | +if ENABLE_ZMQ:
  84 | +    try:
  85 | +        import zmq
  86 | +    except ImportError as e:
  87 | +        print("WARNING: \"import zmq\" failed. Set ENABLE_ZMQ=0 or " \
    laanwj commented at 10:46 AM on April 18, 2016:

    This is no longer a WARNING but an ERROR now

    MarcoFalke commented at 12:54 PM on April 18, 2016:

    Done

  13. MarcoFalke force-pushed on Apr 18, 2016
  14. laanwj merged this on Apr 19, 2016
  15. laanwj closed this on Apr 19, 2016
  16. laanwj referenced this in commit fa9d86f8c4 on Apr 19, 2016
  17. MarcoFalke deleted the branch on Apr 19, 2016
  18. MarcoFalke cross-referenced this on May 7, 2016 from issue Fix multithread CScheduler and reenable test by paveljanik
  19. laanwj referenced this in commit 65fee8e699 on May 9, 2016
  20. laanwj cross-referenced this on May 9, 2016 from issue test: Revert fatal-ness of missing python-zmq by laanwj
  21. MarcoFalke referenced this in commit 4192ff8025 on Jun 9, 2016
  22. MarcoFalke referenced this in commit e0b1bbeae0 on Jun 9, 2016
  23. sickpig referenced this in commit 55b5131b01 on Nov 14, 2016
  24. dagurval cross-referenced this on Sep 3, 2017 from issue Test framework improvements by dagurval
  25. str4d cross-referenced this on Nov 19, 2020 from issue Backport migration from rpc-tests.sh to rpc-tests.py by str4d
  26. zkbot referenced this in commit 025bd44543 on Nov 21, 2020
  27. zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
  28. zkbot referenced this in commit c8896f9907 on Dec 2, 2020
  29. bitcoin locked this on Sep 8, 2021
Contributors
MarcoFalkelaanwj
Labels
Tests
Linked (view graph)
#5677 libevent-based http server#7814 [qa] Switch to py3#8016 Fix multithread CScheduler and reenable test#8030 test: Revert fatal-ness of missing python-zmq
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:55 UTC