My goal was that mininode does not depend on any test framework specific helper functions but looking at the segwit branch, it appears it is less confusing to just do the import. (E.g. https://github.com/sipa/bitcoin/blob/7b539f9bfe4e96a9b30ffdc874aa80e4308c9dec/qa/rpc-tests/test_framework/mininode.py#L250 was doing the .encode('ascii') twice, effectively)
[qa] mininode: Use hexlify wrapper from util #7918
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1604-qaMininodeHexlify changing 1 files +9 −9-
MarcoFalke commented at 4:47 PM on April 20, 2016: member
- MarcoFalke cross-referenced this on Apr 20, 2016 from issue [qa] Switch to py3 by MarcoFalke
-
[qa] mininode: Use hexlify wrapper from util fa79d9bbcd
- MarcoFalke force-pushed on Apr 20, 2016
- jonasschnelli added the label Tests on Apr 21, 2016
-
jonasschnelli commented at 7:08 AM on April 21, 2016: contributor
utACK fa79d9bbcdc511428a796563b5f6f3b481faca47
-
laanwj commented at 12:14 PM on April 21, 2016: member
- MarcoFalke cross-referenced this on Apr 22, 2016 from issue Segregated witness by sipa
-
MarcoFalke commented at 9:57 AM on April 22, 2016: member
Closing for now
- MarcoFalke closed this on Apr 22, 2016
- MarcoFalke deleted the branch on Apr 22, 2016
- bitcoin locked this on Sep 8, 2021
Contributors
Labels