net: use the proxy if overriden when doing v2->v1 reconnections #35319

pull vasild wants to merge 1 commits into bitcoin:master from vasild:keep_using_override_proxy_for_v1_reconnects changing 2 files +11 −1

vasild commented at 5:11 AM on May 19, 2026: contributor

OpenNetworkConnection() supports overriding the proxy to use for connecting. However when v2 connection is attempted and it fails a v1 connection is tried without that proxy.

Store the override proxy in CNode and pass it to CConnman::m_reconnections to be used for v1 retries.

This is a serious flaw I have overlooked when the override proxy is used for private broadcast connections. Reported in https://www.erisian.com.au/bitcoin-core-dev/log-2026-05-18.html#l-234

net: use the proxy if overriden when doing v2->v1 reconnections

`OpenNetworkConnection()` supports overriding the proxy to use for
connecting. However when v2 connection is attempted and it fails a v1
connection is tried without that proxy.

Store the override proxy in `CNode` and pass it to
`CConnman::m_reconnections` to be used for v1 retries.

65c790e841

DrahtBot added the label P2P on May 19, 2026
DrahtBot commented at 5:11 AM on May 19, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35319.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Contributors

vasild

DrahtBot

Labels

P2P

net: use the proxy if overriden when doing v2->v1 reconnections #35319

Code Coverage & Benchmarks

Reviews