net: [refactor] Prefer integral types in CNodeStats #20786

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-net changing 3 files +8 −7

MarcoFalke commented at 3:15 PM on December 28, 2020: member

Currently, strings are stored for what are actually integral (strong) enum types. This is fine, because the strings are only used as-is for the debug log and RPC. However, it complicates using them in the GUI. User facing strings in the GUI should be translated and only string literals can be picked up for translation, not runtime std::strings.

Fix that by removing the std::string members and replace them by strong enum integral types.
MarcoFalke commented at 3:16 PM on December 28, 2020: member

Picked up from #20778 and #20779 . Credits go to @jonatack

<!-- https://cirrus-ci.com/build/4717795785048064
fanquake added the label P2P on Dec 28, 2020
fanquake added the label Refactoring on Dec 28, 2020
DrahtBot commented at 5:09 PM on December 28, 2020: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
DrahtBot cross-referenced this on Dec 28, 2020 from issue refactor, net: Increase CNode data member encapsulation by hebasto
DrahtBot cross-referenced this on Dec 28, 2020 from issue net: assert CNode::m_inbound_onion is inbound in ctor, add getter, unit tests by jonatack
DrahtBot cross-referenced this on Dec 28, 2020 from issue multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky
practicalswift commented at 9:05 PM on December 28, 2020: contributor

Concept ACK
DrahtBot cross-referenced this on Dec 28, 2020 from issue Multiprocess bitcoin by ryanofsky
promag commented at 10:32 PM on December 28, 2020: member

ACK 7f126f2da6.
MarcoFalke force-pushed on Dec 29, 2020
MarcoFalke force-pushed on Dec 29, 2020
MarcoFalke force-pushed on Dec 29, 2020
MarcoFalke force-pushed on Dec 29, 2020
DrahtBot cross-referenced this on Dec 29, 2020 from issue Net: Move ping data to net_processing by jnewbery
ajtowns commented at 2:05 AM on December 30, 2020: contributor

Concept ACK.
SoraKohaku commented at 3:17 AM on December 30, 2020: none

Rebased ok.
DrahtBot added the label Needs rebase on Jan 2, 2021
MarcoFalke force-pushed on Jan 2, 2021
DrahtBot removed the label Needs rebase on Jan 2, 2021
promag approved
promag commented at 6:21 PM on January 2, 2021: member

Code review ACK 6e7e053a94829dbbdcede5cc27c78142dca85aef.
DrahtBot cross-referenced this on Jan 6, 2021 from issue net: Move SocketSendData lock annotation to header by MarcoFalke
Expose integral m_conn_type in CNodeStats, remove m_conn_type_string faecb74562
MarcoFalke force-pushed on Jan 7, 2021
MarcoFalke commented at 2:20 PM on January 7, 2021: member

Rebased due to trivial conflict in adjacent line
bitcoin deleted a comment on Jan 7, 2021
jonatack commented at 7:39 PM on January 7, 2021: contributor

Code review ACK faecb74562d012a336837d3b39572c235ad2eb9d
theStack approved
theStack commented at 2:12 PM on January 8, 2021: contributor

LGTM Code review ACK faecb74562d012a336837d3b39572c235ad2eb9d 🌲
MarcoFalke merged this on Jan 8, 2021
MarcoFalke closed this on Jan 8, 2021
MarcoFalke deleted the branch on Jan 8, 2021
jonatack cross-referenced this on Jan 8, 2021 from issue Peer details: replace Direction with Connection Type by jonatack
sidhujag referenced this in commit 5e1af32137 on Jan 8, 2021
luke-jr referenced this in commit 11a9378aad on Jan 28, 2021
bitcoin locked this on Aug 16, 2022