net, p2p, gui: replace direction with connection type in gui peer details window #20778

pull jonatack wants to merge 5 commits into bitcoin:master from jonatack:display-peer-conn-types changing 7 files +36 −10
  1. jonatack commented at 10:28 PM on December 26, 2020: contributor

    This is a migration of https://github.com/bitcoin-core/gui/pull/163 @ 3707f8c (#163) to this repo. The initial version of the pull only changed gui code; however, reviewers suggested changes and refactoring that involve this repo, so I've ported it here. Please see the original pull for the review up to this point. Closes https://github.com/bitcoin-core/gui/issues/159.

    Screenshot from 2020-12-25 22-40-09

  2. net: expose CNode::m_conn_type in CNodeStats a60f67b2fb
  3. gui: create GUIUtil::ConnectionTypeToQString utility function 4335c4fd28
  4. gui: replace Direction with Connection Type in peer details 8e7f82a6a8
  5. gui: improve connection type tooltip 6cd242c50f
  6. p2p, rpc, refactor: remove CNodeStats::m_conn_type_string 3707f8c508
  7. jonatack cross-referenced this on Dec 26, 2020 from issue Peer details: replace Direction with Connection Type by jonatack
  8. DrahtBot added the label GUI on Dec 26, 2020
  9. DrahtBot added the label P2P on Dec 26, 2020
  10. DrahtBot added the label RPC/REST/ZMQ on Dec 26, 2020
  11. DrahtBot commented at 11:40 PM on December 26, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20779 (net, rpc, gui: add network to peers window and peer details by jonatack)
    • #20373 (refactor, net: Increase CNode data member encapsulation by hebasto)
    • #20210 (net: assert CNode::m_inbound_onion is inbound in ctor, add getter, unit tests by jonatack)
    • #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  12. DrahtBot cross-referenced this on Dec 27, 2020 from issue refactor, net: Increase CNode data member encapsulation by hebasto
  13. DrahtBot cross-referenced this on Dec 27, 2020 from issue net: assert CNode::m_inbound_onion is inbound in ctor, add getter, unit tests by jonatack
  14. DrahtBot cross-referenced this on Dec 27, 2020 from issue multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky
  15. DrahtBot cross-referenced this on Dec 27, 2020 from issue Multiprocess bitcoin by ryanofsky
  16. DrahtBot cross-referenced this on Dec 27, 2020 from issue net, rpc, gui: add network to peers window and peer details by jonatack
  17. jonatack commented at 3:05 PM on December 28, 2020: contributor

    Apparently following the CONTRIBUTING.md guide isn't the right way to go about this.

    Up for grabs.

  18. jonatack closed this on Dec 28, 2020
  19. MarcoFalke cross-referenced this on Dec 28, 2020 from issue net: [refactor] Prefer integral types in CNodeStats by MarcoFalke
  20. bitcoin locked this on Feb 15, 2022
Contributors
jonatackDrahtBot
Labels
GUIRPC/REST/ZMQP2P
Linked (view graph)
#163 Fix for #156: UPnP segfault when no valid UPnP IGDs are found.#20786 net: [refactor] Prefer integral types in CNodeStats
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC