refactor, net: Increase CNode data member encapsulation #20373

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:201111-cnode changing 1 files +38 −45
  1. hebasto commented at 5:13 PM on November 11, 2020: member

    All protected CNode data members could be private.

  2. DrahtBot added the label P2P on Nov 11, 2020
  3. hebasto force-pushed on Nov 11, 2020
  4. DrahtBot added the label Needs rebase on Nov 11, 2020
  5. hebasto commented at 5:27 PM on November 11, 2020: member

    cc @troygiorshev @jnewbery

  6. DrahtBot removed the label Needs rebase on Nov 11, 2020
  7. jnewbery commented at 8:01 PM on November 11, 2020: member

    Concept ACK making protected members private if they don't need to be protected. I'll review once #19673 is merged and this is rebased.

  8. practicalswift commented at 8:43 PM on November 11, 2020: contributor

    Concept ACK

  9. DrahtBot commented at 12:02 AM on November 12, 2020: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  10. DrahtBot cross-referenced this on Nov 12, 2020 from issue net: assert CNode::m_inbound_onion is inbound in ctor, add getter, unit tests by jonatack
  11. DrahtBot cross-referenced this on Nov 12, 2020 from issue Move cs_vSend into SocketSendData and resolve RecordBytesSent lock inconsistency by troygiorshev
  12. DrahtBot cross-referenced this on Nov 12, 2020 from issue Per-Peer Message Capture by troygiorshev
  13. DrahtBot cross-referenced this on Nov 12, 2020 from issue Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli
  14. promag commented at 11:14 AM on November 14, 2020: member

    Concept ACK.

    I'd drop the "consolidate" commit. But if it's kept then it could be marked move-only. Also, there's an unnecessary public:.

  15. DrahtBot cross-referenced this on Dec 7, 2020 from issue eBPF Linux tracepoints by jb55
  16. DrahtBot cross-referenced this on Dec 14, 2020 from issue refactor: Remove nMyStartingHeight from CNode/Connman by MarcoFalke
  17. DrahtBot cross-referenced this on Dec 20, 2020 from issue p2p: Add DISABLETX message for negotiating block-relay-only connections by sdaftuar
  18. DrahtBot cross-referenced this on Dec 26, 2020 from issue net, p2p, gui: replace direction with connection type in gui peer details window by jonatack
  19. sipa commented at 5:09 AM on December 27, 2020: member

    utACK 75f7e47b3ae59b7a8b1f5ec86ac281403a50a604

  20. MarcoFalke commented at 8:51 AM on December 27, 2020: member

    Tend to NACK for the same reason: #19673#pullrequestreview-557045721

  21. DrahtBot cross-referenced this on Dec 28, 2020 from issue net: [refactor] Prefer integral types in CNodeStats by MarcoFalke
  22. DrahtBot cross-referenced this on Dec 29, 2020 from issue Net: Move ping data to net_processing by jnewbery
  23. DrahtBot cross-referenced this on Dec 31, 2020 from issue net: Move RecordBytesSent() call out of cs_vSend lock by jnewbery
  24. DrahtBot added the label Needs rebase on Jan 2, 2021
  25. jnewbery commented at 9:43 AM on January 6, 2021: member

    @hebasto could you rebase now that #20816 is merged?

  26. hebasto force-pushed on Jan 9, 2021
  27. hebasto commented at 9:17 AM on January 9, 2021: member

    Updated 75f7e47b3ae59b7a8b1f5ec86ac281403a50a604 -> 7f20edf4bb827a368b8eaf8d2c22643d5935c613 (pr20373.01 -> pr20373.02). @jnewbery

    @hebasto could you rebase now that #20816 is merged?

    Done. @promag

    ... if it's kept then it could be marked move-only.

    Done.

    Also, there's an unnecessary public:.

    Fixed.

  28. DrahtBot cross-referenced this on Jan 9, 2021 from issue fuzz: net permission flags in net processing by MarcoFalke
  29. jnewbery commented at 10:47 AM on January 9, 2021: member

    ACK 7f20edf4bb827a368b8eaf8d2c22643d5935c613

    Verified that this is move-only, except for making the protected members private.

    Thanks for cleaning this up!

  30. DrahtBot removed the label Needs rebase on Jan 9, 2021
  31. DrahtBot added the label Needs rebase on Jan 10, 2021
  32. refactor, move-only: Relocate CNode private members acebb79d3f
  33. refactor, net: Increase CNode data member encapsulation
    All protected CNode data members could be private.
    3642b2ed34
  34. hebasto force-pushed on Jan 10, 2021
  35. hebasto commented at 10:06 AM on January 10, 2021: member

    Updated 7f20edf4bb827a368b8eaf8d2c22643d5935c613 -> 3642b2ed34e6609e8de558b352516daadb12cac1 (pr20373.02 -> pr20373.03) due to the conflict with #20881.

  36. DrahtBot removed the label Needs rebase on Jan 10, 2021
  37. jnewbery commented at 10:40 AM on January 11, 2021: member

    utACK 3642b2ed34e6609e8de558b352516daadb12cac1

  38. MarcoFalke commented at 12:09 PM on January 11, 2021: member

    review ACK 3642b2ed34e6609e8de558b352516daadb12cac1 🏛

    <details><summary>Show signature and timestamp</summary>

    Signature:

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK 3642b2ed34e6609e8de558b352516daadb12cac1 🏛
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgpSgwAiwjdT13xFBxwJQmARjPmO8p8A7XcH2TDGrYMjehHgN9z/c6LajnsGLrf
HxU581vUH1HnWmjnSFdlQOKC/IDRiUDw9ogpakbjVi4Z1+KJnXEwJCDoCQepAKGA
adpBXg1jZLbLXlyhsiladQb5mAEZ0Cbru8NnXIriUP0SFgM7RGR7EaP9G0BUVqYx
3rpDxXtsUmtaZ7Y2/2SpTABh2UEK0ya1v1x8ILlWwz1YhqTEunSI8VwNffxCiVBn
V+oYGbKEyM/zg6x3MQnnX1plXgoz0XEOqmqqK12jtkTQAknWp7tQj7DhSCbSjLaS
ojE2LPFc5GhYDA0nvMq8N//Bm6yd6Z29WK5x8trAGmOEbpGxcyqrjN4Nnuw0O0Ai
hxt0XnQ6YMjeFvh5xzrIQEQwTd2bttrk6CiAf46hnwwmXwHbNwecTRQtj4+7LZlf
frOLEwBnFnQiOZjkiIXP0Q1L3pfQYKSNxr8b426QUBhQBNLojP+xBw4eLX3Gu3Iq
zSgvcVPd
=leU8
-----END PGP SIGNATURE-----

    Timestamp of file with hash a0e7b38da83edfebd9fb41f063e4ec58f924d3f47816589b67b81a023d3dcd94 -

    </details>

  39. MarcoFalke merged this on Jan 11, 2021
  40. MarcoFalke closed this on Jan 11, 2021
  41. hebasto deleted the branch on Jan 11, 2021
  42. sidhujag referenced this in commit 5d6c7186ed on Jan 11, 2021
  43. bitcoin locked this on Aug 16, 2022
Contributors
hebastojnewberypracticalswiftDrahtBotpromagsipaMarcoFalke
Labels
P2P
Linked (view graph)
#19673 Move cs_vSend into SocketSendData and resolve RecordBytesSent lock inconsistency
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC