fanquake
commented at 7:44 AM on August 14, 2020:
member
Opening this for visibility. Apart from it probably being time to use a newer version of Qt for releases, an update is required so that we are using a version which has a C++17 mode.
There's a lot of commits here, because I've made some changes (like rebasing our patches), that aren't strictly necessary. There are also some changes, like bumping the minimum required macOS version, that will likely happen separate, as part of the C++17 migration. So this change will end up being a bit smaller.
The biggest change here is that Qt no longer has internal xcb libs, so we need to build the requirements ourselves. This also means some additional build-time tools, such as yacc (from bison) are also required; to build xkbcommon.
I've tested this on Ubuntu; although it'd be great if more people could test with their particular brand of Linux desktop.
Cross-compiled Windows and macOS builds compile and run, but the GUI currently looks a bit broken on both. i.e macOS seems to look a bit like an older version of Windows:
I haven't had enough time to fully investigate (also why there's some WIP commits), so if anyone wants to dig in and see what Qt has changed since 5.9.x feel free.
fanquake added the label GUI on Aug 14, 2020
fanquake added the label Build system on Aug 14, 2020
MarcoFalke added this to the milestone 0.22.0 on Aug 14, 2020
MarcoFalke
commented at 7:52 AM on August 14, 2020:
member
Added 0.22 milestone based on the assumption that none of this is required to build with a qt5.15 system package? (Only depends changes here?)
fanquake
commented at 7:59 AM on August 14, 2020:
member
the assumption that none of this is required to build with a qt5.15 system package?
As far as I'm aware people have already been building with Qt 5.15, and that has been working after #19097.
jonasschnelli
commented at 8:23 AM on August 14, 2020:
contributor
Cross-compiled Windows and macOS builds compile and run, but the GUI currently looks a bit broken on both. i.e macOS seems to look a bit like an older version of Windows:
vasild
commented at 12:43 PM on August 19, 2020:
contributor
There are a bunch of compilation warnings on master and on this PR with Qt 5.15.0 like:
src/qt/transactionview.cpp:587:13: warning: 'QDateTime' is deprecated: Use QDate::startOfDay() [-Wdeprecated-declarations]
QDateTime(dateTo->date()).addDays(1));
^
Here is a fix:
<details>
<summary>Fix -Wdeprecated-declarations warnings with Qt 5.15</summary>
DrahtBot
commented at 8:32 PM on August 20, 2020:
contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
#20641 (depends: Use Qt top-level build facilities by hebasto)
#18298 (build: Fix Qt processing of configure script for depends with DEBUG=1 by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake
commented at 12:15 PM on August 24, 2020:
member
I've fixed up a bunch of things here.
Rebased for #19689.
Dropped the [WIP] qt commits and merged the relevant changes in to the qt 5.15.x commit.
Modified the libxcb_util_image fix to be a patch file rather than using sed.
Added a commit that should be enough to get the CI running.
Fixed the docs for the dependency changes.
Note that Qt 5.15.1 has been tagged (no downloads yet), so once that's up I'll swap over.
Also dumped some output using @hebasto's patch. Turns out the macOS UI looks like Windows because the Windows style is being used.. Unclear why this is happening. Will investigate. Debug output:
2020-08-24T11:22:47.398810Z [main] Bitcoin Core version v0.20.99.0-1971aead8-dirty (release build)
2020-08-24T11:22:47.398842Z [main] Qt 5.15.0 (static), plugin=cocoa (static)
2020-08-24T11:22:47.398936Z [main] Static Plugin: {"IID":"org.qt-project.Qt.QPA.QPlatformIntegrationFactoryInterface.5.3","MetaData":{"Keys":["cocoa"]},"archreq":0,"className":"QCocoaIntegrationPlugin","debug":false,"version":331520}
2020-08-24T11:22:47.398959Z [main] Style=windows / QWindowsStyle
2020-08-24T11:22:47.398973Z [main] System: macOS 10.15, x86_64-little_endian-lp64
2020-08-24T11:22:47.398987Z [main] Screen: Color LCD 1680x1050, pixel ratio=2.0
2020-08-24T11:22:47.398997Z [main] Screen: LG HDR 4K 2560x1440, pixel ratio=2.0
2020-08-24T11:22:47.958407Z [main] GUI: Populating font family aliases took 512 ms. Replace uses of missing font family ".AppleSystemUIFont,13,-1,5,50,0,0,0,0,0" with one that exists to avoid this cost.
2020-08-24T11:22:48.816413Z [main] GUI: initializeResult : Initialization result: true
2020-08-24T11:22:48.821713Z [main] GUI: Platform customization: "macosx"
Building libxkbcommon...
make[1]: Entering directory `/home/travis/build/hebasto/bitcoin/depends/work/build/i686-pc-linux-gnu/libxkbcommon/0.8.4-b76cb6131e8'
YACC src/xkbcomp/parser.c
./build-aux/ylwrap: line 176: yacc: command not found
fanquake
commented at 12:03 PM on August 25, 2020:
fatal error: variant: No such file or directory
The problem is that the compiler doesn't support C++17. GCC didn't introduce support for std::variant (in libstdc++) until the 7.1 release. Xenial ships with 5.3.1. So when Qts build system tests for C++17 support by checking it can compile something using std::variant, it's failing as expected.
MarcoFalke
commented at 9:29 AM on August 25, 2020:
member
This is currently assigned to the 0.22 milestone, by which time both centos:7 and xenial are no longer supported. So no need to test on them right now.
hebasto
commented at 9:36 AM on August 25, 2020:
member
This is currently assigned to the 0.22 milestone, by which time both centos:7 and xenial are no longer supported. So no need to test on them right now.
So let's remove them from CI jobs in this PR.
hebasto
commented at 10:09 AM on August 25, 2020:
member
macOS 10.12 build error (on Travis):
Project ERROR: Cannot run target compiler 'x86_64-apple-darwin16-clang++'. Output:
===================
===================
Maybe you forgot to setup the environment?
hebasto
commented at 10:40 AM on August 25, 2020:
member
fanquake referenced this in commit 2562d5d238 on Aug 27, 2020
fanquake force-pushed on Aug 27, 2020
fanquake
commented at 10:41 AM on August 27, 2020:
member
Rebased after #19761.
Fixed-up QTSERVICE, thanks @hebasto.
Dropped the freetype back-compat patch. See commit message for reasoning.
Turned off some additional Qt features, like the markdown reader and SQL item models. We also don't use GSS but no-gss doesn't seem to work.
Some more TODO:
Figure out how much more of our patching / hacking we can drop.
I'm also planning on splitting anything C++17-bump related into a separate PR, so it's clear what will be going in before this PR is merged, and what isn't required testing wise. i.e building this assumes the use of a C++17 capable compiler.
hebasto
commented at 12:10 PM on August 27, 2020:
member
Tested 3f4fe21d3fa04cc8f284dccae03a5e4a27dba9e4, still having:
In file included from rhi/qrhi.cpp:49:0:
rhi/qrhid3d11_p_p.h:57:10: fatal error: dxgi1_3.h: No such file or directory
#include <dxgi1_3.h>
^~~~~~~~~~~
compilation terminated.
Project ERROR: Cannot run target compiler 'x86_64-apple-darwin16-clang++'. Output:
===================
===================
Maybe you forgot to setup the environment?
fanquake
commented at 12:39 AM on August 28, 2020:
member
I've managed to fix Windows build
Is this fixing a problem other than dxgi1_3.h: No such file or directory mentioned above? In that case the problem, and the solution is pretty clear. The CI is using a version of the mingw headers that are too old to build Qt. This will be fixed when we use a newer version of Ubuntu for builds.
I'm also not sure that disabling RHI is the right approach, as it seems that's what Qt is going to be using for all it's graphics and rendering from Qt 6 on-wards. Also, the blog post you linked says " For Qt 5.15 LTS RHI is an opt-in functionality", so is a patch actually required to disable it? Shouldn't there be (a combination of) configure flags that will opt you in/out of the functionality?
sidhujag referenced this in commit a012bea252 on Aug 28, 2020
hebasto
commented at 7:08 AM on August 28, 2020:
member
Is this fixing a problem other than dxgi1_3.h: No such file or directory mentioned above?
Not sure what do you mean exactly.
In that case the problem, and the solution is pretty clear. The CI is using a version of the mingw headers that are too old to build Qt. This will be fixed when we use a newer version of Ubuntu for builds.
I'm also not sure that disabling RHI is the right approach, as it seems that's what Qt is going to be using for all it's graphics and rendering from Qt 6 on-wards. Also, the blog post you linked says " For Qt 5.15 LTS RHI is an opt-in functionality", so is a patch actually required to disable it? Shouldn't there be (a combination of) configure flags that will opt you in/out of the functionality?
I have not found any configure options or features to disable RHI. By the time we switch to Qt 6 we will use a newer version of Ubuntu for builds for sure :)
hebasto
commented at 7:28 AM on August 28, 2020:
member
IIUC, RHI is used for rendering in Qt Quick framework, not in Qt Widgets.
MarcoFalke
commented at 11:14 AM on August 28, 2020:
member
There will probably be fewer warning by bumping the qt version, so you might be able to remove the Temporary workaround for [#16368](/github-metadata-backup-bitcoin-bitcoin/16368/)
hebasto cross-referenced this on Aug 28, 2020 from issue Embed monospaced font by hebasto
fanquake force-pushed on Aug 31, 2020
fanquake
commented at 3:16 AM on August 31, 2020:
member
Rebased, and updated the win64 CI now that #18921 has been merged.
hebasto
commented at 4:29 PM on September 2, 2020:
member
Project ERROR: Cannot run target compiler 'x86_64-apple-darwin16-clang++'. Output:
===================
===================
Maybe you forgot to setup the environment?
fanquake marked this as ready for review on Jan 5, 2021
fanquake
commented at 4:38 AM on January 5, 2021:
member
The issue with with libxkbcommon is fixed by installing bison rather than byacc
The CI changes to install bison have now been merged into the "qt 5.15.2" commit, rather than being in a separate WIP commit. Also added bb38e8a30de2278b4bd9dae6f80cc097892dd5c8 to stop using -optimized-tools in release mode. We can split off more commits if need be.
While this still has at least one outstanding issue, which is fixing the macOS cross-compile, I'm going to take it out of draft. If anyone wants to help debug why the macOS theming (when built using locally using depends) isn't correct, that'd be handy. It also needs more testing across OSs, particularly Linux.
fanquake
commented at 8:24 AM on January 5, 2021:
member
I've now fixed the macOS cross-compilation issue and added a commit that disables some SDK version checking, as that would try and invoke xcrun, which isn't available when cross-compiling. I've also added a commit (262e02995912a9caa4026105d9ce6237965e8600) which might help debug the theme issues.
fanquake force-pushed on Jan 5, 2021
DrahtBot added the label Needs rebase on Jan 5, 2021
fanquake force-pushed on Jan 5, 2021
DrahtBot removed the label Needs rebase on Jan 5, 2021
jarolrod
commented at 9:06 PM on January 13, 2021:
member
fanquake added this to the "Blockers" column in a project
laanwj
commented at 1:27 PM on January 25, 2021:
member
Any consensus surrounding Qt dropping LTS for Qt 5.15?
I don't think that's too relevant here. It means that upstream won't do any updates on top of 5.15. But we generally don't track minor versions of Qt so for us it makes no difference. The next Qt bump after this is likely to be 6.x.
laanwj
commented at 3:52 PM on January 25, 2021:
member
I'm confused by this Win64 CI error:
make[4]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
Running tests: allocator_tests from test/allocator_tests.cpp
wine: fixed a temporary directory error, please try running the same command again
make[3]: *** [Makefile:16848: test/addrman_tests.cpp.test] Error 1
make[3]: *** Waiting for unfinished jobs....
wine: fixed a temporary directory error, please try running the same command again
make[3]: *** [Makefile:16848: test/allocator_tests.cpp.test] Error 1
wine: created the configuration directory '/root/.wine'
wine: chdir to /tmp/wine-4SkHOY/server-32-27828a : No such file or directory
wine: chdir to /tmp/wine-2CwwWn/server-32-27828a : No such file or directory
make[3]: *** [Makefile:16848: test/amount_tests.cpp.test] Error 1
make[3]: *** [Makefile:16848: test/arith_uint256_tests.cpp.test] Error 1
make[3]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
make[2]: *** [Makefile:15367: check-am] Error 2
make[2]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
make[1]: *** [Makefile:15052: check-recursive] Error 1
make[1]: Leaving directory '/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32/src'
make: *** [Makefile:813: check-recursive] Error 1
Already tried restarting it, to no avail.
MarcoFalke
commented at 3:56 PM on January 25, 2021:
member
Looks like an upstream bug. Locally I could fix it by running the command twice, IIRC
MarcoFalke added the label Needs gitian build on Jan 25, 2021
MarcoFalke added the label Needs Guix build on Jan 25, 2021
in
ci/test/00_setup_env_win64.sh:10
in
5cdd5e775eoutdated
6 | @@ -7,7 +7,7 @@
7 | export LC_ALL=C.UTF-8
8 |
9 | export CONTAINER_NAME=ci_win64
10 | -export DOCKER_NAME_TAG=ubuntu:18.04 # Check that bionic can cross-compile to win64 (bionic is used in the gitian build as well) 11 | +export DOCKER_NAME_TAG=ubuntu:20.04
MarcoFalke
commented at 4:37 PM on January 25, 2021:
compiling .rcc/release/qrc_qmake_webgradients.cpp
In file included from rhi/qrhi.cpp:49:0:
rhi/qrhid3d11_p_p.h:57:10: fatal error: dxgi1_3.h: No such file or directory
#include <dxgi1_3.h>
^~~~~~~~~~~
compilation terminated.
Makefile.Release:71663: recipe for target '.obj/release/qrhi.o' failed
make[3]: *** [.obj/release/qrhi.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from rhi/qrhid3d11.cpp:37:0:
rhi/qrhid3d11_p_p.h:57:10: fatal error: dxgi1_3.h: No such file or directory
#include <dxgi1_3.h>
^~~~~~~~~~~
compilation terminated.
Makefile.Release:72684: recipe for target '.obj/release/qrhid3d11.o' failed
make[3]: *** [.obj/release/qrhid3d11.o] Error 1
make[3]: Leaving directory '/tmp/cirrus-ci-build/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-102170435c3/qtbase/src/gui'
Makefile:45: recipe for target 'release' failed
make[2]: *** [release] Error 2
make[2]: Leaving directory '/tmp/cirrus-ci-build/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-102170435c3/qtbase/src/gui'
Makefile:423: recipe for target 'sub-gui' failed
make[1]: *** [sub-gui] Error 2
make[1]: Leaving directory '/tmp/cirrus-ci-build/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-102170435c3/qtbase/src'
funcs.mk:273: recipe for target '/tmp/cirrus-ci-build/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-102170435c3/./.stamp_built' failed
make: *** [/tmp/cirrus-ci-build/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-102170435c3/./.stamp_built] Error 2
make: Leaving directory '/tmp/cirrus-ci-build/depends'
Exit status: 2
MarcoFalke
commented at 4:38 PM on January 25, 2021:
Do the gitian builds pass? If yes, why do they and the ci doesn't?
fanquake
commented at 1:01 AM on January 26, 2021:
I don't like this change, but without it the ci fails:
A newer version of mingw-w64 & headers is required to build this version of Qt, so we (essentially) have to use a newer version of Ubuntu in the CI & gitian (I'll add those changes, but will PR them separate in advance). This was also discussed above.
MarcoFalke
commented at 7:03 AM on January 26, 2021:
DrahtBot removed the label Needs gitian build on Jan 26, 2021
MarcoFalke
commented at 7:02 AM on January 26, 2021:
member
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-apple-darwin18'
+ make -j1 -C src check-security
make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-apple-darwin18/src'
Checking binary security...
make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-apple-darwin18/src'
+ make -j1 -C src check-symbols
make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-apple-darwin18/src'
Checking macOS dynamic libraries...
Security is not in ALLOWED_LIBRARIES!
Metal is not in ALLOWED_LIBRARIES!
QuartzCore is not in ALLOWED_LIBRARIES!
IOSurface is not in ALLOWED_LIBRARIES!
ColorSync is not in ALLOWED_LIBRARIES!
CoreVideo is not in ALLOWED_LIBRARIES!
qt/bitcoin-qt: failed DYNAMIC_LIBRARIES
Makefile:14994: recipe for target 'check-symbols' failed
make: *** [check-symbols] Error 1
make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-apple-darwin18/src'
compiling rhi/qrhi.cpp
In file included from rhi/qrhi.cpp:49:0:
rhi/qrhid3d11_p_p.h:57:10: fatal error: dxgi1_3.h: No such file or directory
#include <dxgi1_3.h>
^~~~~~~~~~~
compilation terminated.
Makefile.Release:71663: recipe for target '.obj/release/qrhi.o' failed
make[3]: *** [.obj/release/qrhi.o] Error 1
make[3]: Leaving directory '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-b4b0c80531f/qtbase/src/gui'
Makefile:45: recipe for target 'release' failed
make[2]: *** [release] Error 2
make[2]: Leaving directory '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-b4b0c80531f/qtbase/src/gui'
Makefile:423: recipe for target 'sub-gui' failed
make[1]: *** [sub-gui] Error 2
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-b4b0c80531f/qtbase/src'
funcs.mk:273: recipe for target '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-b4b0c80531f/./.stamp_built' failed
make: *** [/home/ubuntu/build/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.15.2-b4b0c80531f/./.stamp_built] Error 2
make: Leaving directory '/home/ubuntu/build/bitcoin/depends'
Building libxkbcommon...
make[1]: Entering directory '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-68d09a7117d'
YACC src/xkbcomp/parser.c
./build-aux/ylwrap: line 176: yacc: command not found
Makefile:1705: recipe for target 'src/xkbcomp/parser.c' failed
make[1]: *** [src/xkbcomp/parser.c] Error 127
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-68d09a7117d'
funcs.mk:273: recipe for target '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-68d09a7117d/./.stamp_built' failed
make: *** [/home/ubuntu/build/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-68d09a7117d/./.stamp_built] Error 2
make: Leaving directory '/home/ubuntu/build/bitcoin/depends'
jonasschnelli referenced this in commit 7595183543 on Jan 28, 2021
sidhujag referenced this in commit 7310454603 on Jan 28, 2021
laanwj removed this from the "Blockers" column in a project
MarcoFalke referenced this in commit ca85449f22 on Feb 8, 2021
DrahtBot added the label Needs rebase on Feb 8, 2021
DrahtBot
commented at 11:55 AM on February 8, 2021:
contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
<sub>Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".</sub>
sidhujag referenced this in commit f2c9a6f37e on Feb 8, 2021
fanquake force-pushed on Feb 9, 2021
fanquake removed the label Needs rebase on Feb 9, 2021
fanquake added the label Needs gitian build on Feb 9, 2021
DrahtBot added the label Needs rebase on Feb 9, 2021
fanquake removed the label Needs rebase on Feb 9, 2021
bitcoin deleted a comment on Feb 9, 2021
DrahtBot
commented at 9:11 AM on February 9, 2021:
contributor
Win64 [unit tests, no gui tests, no boost::process, no functional tests] [bionic]:
In file included from rhi/qrhi.cpp:49:0:
rhi/qrhid3d11_p_p.h:57:10: fatal error: dxgi1_3.h: No such file or directory
#include <dxgi1_3.h>
^~~~~~~~~~~
compilation terminated.
fanquake force-pushed on Feb 9, 2021
fanquake force-pushed on Feb 9, 2021
build: remove qt libpng powerpc patch9f6ece4890
build: xproto 7.0.311ecaffcc2a
build: libXau 1.0.9eecb1eb911
build: xcb_proto 1.1445eda952b3
build: expat 2.2.10c1fb969655
build: freetype 2.10.4
Co-authored-by: mammix2 <mammix2@hotmail.com>
f27f581801
build: libxcb 1.14
Minimum required libxcb to build qt 5.15.x is 1.11.
https://codereview.qt.nokia.com/c/qt/qtbase/+/253905
Some plugins have been re-enabled as they are required by Qt.
9c157a4ca4
build: add xkbcommon 0.8.4
Currently 0.8.4 because at 0.9.0 they switch from autotools to meson..
This also requires yacc (bison) to be available at build time.
5e699b1bb0
build: add libxcb_util 0.4.008d98b4dee
build: add libxcb_util_render 0.3.9ef4bfd7194
build: add libxcb_util_keysyms 0.4.0f83f196357
build: add libxcb_util_image 0.4.09bc4c056f1
build: patch around broken pkg-config in libxcb_util_image3557e7376a
build: add libxcb_util_wm 0.4.1
Required for xcb_icccm.
d2a8432fec
build: qt 5.15.2eb612c1f86
depends: remove fix_configure_mac.patch from qt
Fixed upstream in Qt 5.11.0RC1
https://bugreports.qt.io/browse/QTBUG-67286
7907064f23
depends: remove fix_riscv64_arch.patch from qt
Was fixed upstream in 6a39e49a6cdeb28a04a3657bb6a22f848d5dfa9d
2aadc37c67
depends: remove fix_rcc_determinism.patch from qt
Fixed upstream in https://bugreports.qt.io/browse/QTBUG-62511
95081b3470
depends: remove xkb-default.patch from qt
This was removed upstream in d5abf545971da717014d316127045fc19edbcd65
dc7b699804
build: update fix_pkg_config.patch for qt 5.15fbd60d9922
build: update fix_no_printer.patch for qt 5.152ec8eade4f
build: remove fix_android_qmake_conf.patch from qt build
This may need to be reinstated in some capacity, but I haven't looked
through the changes here, and have no ability to test them.
f27def14c1
build: update no-xlib.patch for qt 5.150367ed51f7
build: update fix_android_jni_static.patch for qt 5.150b349047d7
build: remove freetype_back_compat.patch for qt 5.15
By the time we ship a release with Qt 5.15, we'll certainly no-longer be
supporting Ubuntu 14.04 and Ubuntu 16.04 ships with FreeType 2.6.1,
which is new enough that using the symbol is no-longer an issue.
The renaming of FT_Get_X11_Font_Format() happened in FreeType 2.6
b54e861ea6
build: no-longer disable dark mode on macOS
We should no-longer have to disable darkmode, as Qt should
properly support it, and we are using a new enough SDK.
2e6fa254ac
build: remove fix_mingw_cross_compile.patch for qt 5.15505098f128
build: only pass -optimized-tools to qt in debug mode
Qt's configure tells us that "-optimized-tools is not useful in -release
mode.", so don't use it there.
34b69c487a
build: disable qt SDK version checking
This tries to invoke xcrun, which is not available when cross-compiling.
Given we are in control of the SDK versions being used, removing this
check has minimal-no effect.
364250b68a
fanquake force-pushed on Feb 10, 2021
DrahtBot
commented at 9:43 PM on February 12, 2021:
contributor
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:54 UTC
