This is needed to compile with Qt 5.15.
qt: Add missing QPainterPath include #19097
pull achow101 wants to merge 1 commits into bitcoin:master from achow101:qpainterpath-include changing 1 files +1 −0-
achow101 commented at 6:58 PM on May 28, 2020: member
-
79b0a69e09
Add missing QPainterPath include
This is needed to compile with Qt 5.15.
- DrahtBot added the label GUI on May 28, 2020
-
laanwj commented at 8:08 PM on May 28, 2020: member
Code review ACK 79b0a69e09c1a912122e6431ea3c530cc292c690
-
MarcoFalke commented at 8:14 PM on May 28, 2020: member
Code review ACK 79b0a69
-
promag commented at 9:18 PM on May 28, 2020: member
Code review ACK 79b0a69e09c1a912122e6431ea3c530cc292c690.
nit, could also forward declare in src/qt/trafficgraphwidget.h.
- fanquake merged this on May 29, 2020
- fanquake closed this on May 29, 2020
- bitcoin deleted a comment on May 29, 2020
- fanquake added the label Needs backport (0.20) on May 29, 2020
- fanquake added this to the milestone 0.20.1 on May 29, 2020
- promag cross-referenced this on Jun 2, 2020 from issue include QPainterPath to fix compile error with Qt 5.15 by puchu
-
-
promag commented at 9:52 PM on June 2, 2020: member
Definition isn't necessary in the header, forward declaration is enough.
-
puchu commented at 10:00 PM on June 2, 2020: contributor
but what's the benefit, instead of directly including it in the h file?
would actually save one line of code ;)
-
promag commented at 10:05 PM on June 2, 2020: member
It's usually best practice to just include an header when the definition is required to minimize the compiler work.
-
puchu commented at 10:18 PM on June 2, 2020: contributor
makes sense
- luke-jr referenced this in commit 384d3f991c on Jun 4, 2020
- luke-jr cross-referenced this on Jun 4, 2020 from issue [0.20] Add missing QPainterPath include by luke-jr
- MarcoFalke referenced this in commit cd32134bda on Jun 4, 2020
- MarcoFalke removed the label Needs backport (0.20) on Jun 4, 2020
- MiWCryptoCurrency cross-referenced this on Jun 7, 2020 from issue qt: Add missing QPainterPath include by MiWCryptoCurrency
- MiWCryptoCurrency cross-referenced this on Jun 13, 2020 from issue Add missing QPainterPath include by MiWCryptoCurrency
- fanquake cross-referenced this on Jul 14, 2020 from issue Bitcoind not compiling on MacOS 10.15.5 by y471n
- fanquake referenced this in commit b7e16a82c9 on Jul 15, 2020
- fanquake cross-referenced this on Jul 15, 2020 from issue [0.19] Backports by fanquake
- MarcoFalke referenced this in commit 28a9df7d76 on Aug 11, 2020
- fanquake cross-referenced this on Aug 14, 2020 from issue build: Qt 5.15.x by fanquake
- Bushstar referenced this in commit e4ff5b1505 on Oct 21, 2020
- Platinumwrist referenced this in commit 05e2740d92 on Oct 25, 2020
- buzzkillb referenced this in commit c44ebe0ce2 on Dec 5, 2020
- buzzkillb cross-referenced this on Dec 5, 2020 from issue qt: Add missing QPainterPath include by buzzkillb
- blockstreamsatellite referenced this in commit 38fd49d98c on Jan 29, 2021
- backpacker69 referenced this in commit 7bb20aff8c on Mar 28, 2021
- LionCoinMother cross-referenced this on Jun 5, 2021 from issue Compatibility with QT 5.15 by LionCoinMother
- LionCoinMother cross-referenced this on Jun 5, 2021 from issue Compatibility with QT 5.15 by LionCoinMother
- PastaPastaPasta referenced this in commit 4f81faa0d2 on Jun 27, 2021
- PastaPastaPasta referenced this in commit d5ab2cb7d8 on Jun 28, 2021
- PastaPastaPasta referenced this in commit 73ea0c4d41 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 44339c6b54 on Jul 1, 2021
- PastaPastaPasta referenced this in commit eba7d8a6ad on Jul 1, 2021
- PastaPastaPasta referenced this in commit 286290bc77 on Jul 14, 2021
- PastaPastaPasta referenced this in commit 68e1c05e8b on Jul 15, 2021
- bitcoin locked this on Feb 15, 2022
