These aren't dialogs.
gui: Make send and receive widgets extend QWidget #17611
pull promag wants to merge 2 commits into bitcoin:master from promag:2019-11-send-receive-widgets changing 7 files +11 −11-
promag commented at 1:23 PM on November 26, 2019: member
-
gui: ReceiveCoinsDialog now extends QWidget e5ef90b5f6
-
gui: SendCoinDialog now extends QWidget 3337c455e0
-
promag commented at 1:23 PM on November 26, 2019: member
Let me know if I should include script-diff to rename classes and files.
- fanquake added the label GUI on Nov 26, 2019
-
DrahtBot commented at 6:14 PM on November 26, 2019: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18894 (gui: Fix manual coin control with multiple wallets loaded by promag)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
-
hebasto commented at 5:45 PM on November 27, 2019: member
This PR also requires:
- corresponding changes in
forms/*.uifiles - dropping
QDialogslots and signals.
- corresponding changes in
- fanquake cross-referenced this on Feb 4, 2020 from issue qt: Rename intro.* to introdialog.* by hebasto
- DrahtBot cross-referenced this on Feb 11, 2020 from issue gui: Fix manual coin control with multiple wallets loaded by promag
- DrahtBot cross-referenced this on Mar 2, 2020 from issue wip: gui: Refactor to drop client and wallet models setters by promag
- DrahtBot cross-referenced this on May 6, 2020 from issue gui: Fix manual coin control with multiple wallets loaded by promag
- DrahtBot added the label Needs rebase on May 13, 2020
-
DrahtBot commented at 8:21 AM on May 13, 2020: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
-
fanquake commented at 12:38 PM on July 9, 2020: member
This has a concept ACK, but looks like it may need additional (qt only) changes, conversion to a scripted diff where appropriate and in any case needs a rebase. I'm going to suggest re-opening this in https://github.com/bitcoin-core/gui.
- fanquake closed this on Jul 9, 2020
- bitcoin locked this on Feb 15, 2022
Labels