build: Add MSVC project files for bitcoin-wallet-tool #14284

pull ken2812221 wants to merge 3 commits into bitcoin:master from ken2812221:2018-09-21-jnewbery-wallet-tool changing 14 files +743 −10

ken2812221 commented at 1:14 AM on September 21, 2018: contributor

Based on #13926. Add msvc project files for it
fanquake added the label Windows on Sep 21, 2018
DrahtBot commented at 3:38 AM on September 21, 2018: contributor
Reviewers, this pull request conflicts with the following ones:
- #14283 (WIP: Add wallet tool test by promag)
- #13100 (gui: Add dynamic wallets support by promag)
- #12246 (Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot cross-referenced this on Sep 21, 2018 from issue Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled by luke-jr
[PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" 428823c2cc
fixups fdbb2d5872
DrahtBot cross-referenced this on Sep 21, 2018 from issue [Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery
DrahtBot cross-referenced this on Sep 22, 2018 from issue gui: Add dynamic wallets support by promag

in src/wallet/wallettool.cpp:132 in 36877aa5f3 outdated

 120 | +        std::string backup_filename;
 121 | +        if (!WalletBatch::Recover(path, (void*)&dummyWallet, WalletBatch::RecoverKeysOnlyFilter, backup_filename)) {
 122 | +            fprintf(stderr, "Salvage failed\n");
 123 | +            return false;
 124 | +        }
 125 | +        //TODO, set wallets best block to genesis to enforce a rescan

practicalswift commented at 6:59 PM on September 22, 2018:

2018-09-22 20:39:03 cpplint(pr=14284): src/wallet/wallettool.cpp:125:  Should have a space between // and comment  [whitespace/comments

ken2812221 commented at 7:45 PM on September 22, 2018:

This is not my commit, please comment on #13926.

ken2812221 force-pushed on Sep 24, 2018
build: Add MSVC project files for bitcoin-wallet-tool 44a11b0da8
ken2812221 force-pushed on Sep 24, 2018
ken2812221 commented at 2:19 PM on September 24, 2018: contributor

Rebased
DrahtBot cross-referenced this on Sep 24, 2018 from issue WIP: Add wallet tool test by promag
jnewbery commented at 2:21 PM on September 27, 2018: member

Thanks for doing this @ken2812221 . I've squashed your changes into the commit in #13926. (I didn't cherry pick as a separate commit to avoid breaking git bisect for msvc builds).
ken2812221 closed this on Sep 27, 2018
ken2812221 reopened this on Sep 27, 2018
ken2812221 closed this on Sep 27, 2018
ken2812221 deleted the branch on Sep 27, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#13926 [Tools] bitcoin-wallet - a tool for creating and managing wallets offline