WIP: Add wallet tool test #14283

pull promag wants to merge 3 commits into bitcoin:master from promag:2018-09-test-wallet_tool changing 12 files +459 −10

promag commented at 12:39 AM on September 21, 2018: member

Based on #13926, this PR adds a test for the wallet tool.
[PoC] Add wallet inspection and modification tool "bitcoin-wallet-tool" db2678145a
qa: Add wallet tool test 96b2ef77d4
DrahtBot commented at 3:39 AM on September 21, 2018: contributor
Reviewers, this pull request conflicts with the following ones:
- #14284 (build: Add MSVC project files for bitcoin-wallet-tool by ken2812221)
- #13926 ([Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery)
- #13100 (gui: Add dynamic wallets support by promag)
- #12246 (Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fixup! qa: Add wallet tool test 70fca51816
DrahtBot cross-referenced this on Sep 21, 2018 from issue Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled by luke-jr
jnewbery commented at 5:50 PM on September 21, 2018: member

Thanks @promag - I'll review this later.
DrahtBot cross-referenced this on Sep 21, 2018 from issue [Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery
DrahtBot cross-referenced this on Sep 22, 2018 from issue gui: Add dynamic wallets support by promag

in src/wallet/wallettool.cpp:125 in 70fca51816

 120 | +        std::string backup_filename;
 121 | +        if (!WalletBatch::Recover(path, (void*)&dummyWallet, WalletBatch::RecoverKeysOnlyFilter, backup_filename)) {
 122 | +            fprintf(stderr, "Salvage failed\n");
 123 | +            return false;
 124 | +        }
 125 | +        //TODO, set wallets best block to genesis to enforce a rescan

practicalswift commented at 7:01 PM on September 22, 2018:

2018-09-22 20:39:40 cpplint(pr=14283): src/wallet/wallettool.cpp:125:  Should have a space between // and comment  [whitespace/comments] [4]

DrahtBot cross-referenced this on Sep 24, 2018 from issue build: Add MSVC project files for bitcoin-wallet-tool by ken2812221

in test/functional/tool_wallet.py:21 in 70fca51816

  16 | +    def set_test_params(self):
  17 | +        self.num_nodes = 1
  18 | +
  19 | +    def process(self, *args):
  20 | +        binary = self.config["environment"]["BUILDDIR"] + '/src/bitcoin-wallet-tool' + self.config["environment"]["EXEEXT"]
  21 | +        input = None

practicalswift commented at 12:02 PM on September 27, 2018:

Remove this line. It redefines the built-in function input. Furthermore it is unused :-)

jnewbery commented at 2:20 PM on September 27, 2018: member

Looks good. Thanks @promag! I've cherry picked and squashed your commits into #13926 . I'll add my review comments there.
promag closed this on Sep 27, 2018
promag deleted the branch on Sep 27, 2018
bitcoin locked this on Sep 8, 2021

Contributors

Linked (view graph)

#13926 [Tools] bitcoin-wallet - a tool for creating and managing wallets offline