Includes #5618 (which the reasons for rejecting no longer hold true)
Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled #12246
pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:separate_utils changing 6 files +39 −14-
luke-jr commented at 3:55 AM on January 23, 2018: member
- fanquake added the label Tests on Jan 23, 2018
- laanwj assigned theuni on Feb 13, 2018
-
- MarcoFalke added the label Needs rebase on Jun 6, 2018
- luke-jr force-pushed on Aug 31, 2018
- DrahtBot removed the label Needs rebase on Aug 31, 2018
- DrahtBot cross-referenced this on Aug 31, 2018 from issue [Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery
- DrahtBot cross-referenced this on Sep 9, 2018 from issue qa: Run all tests even if wallet is not compiled by MarcoFalke
- DrahtBot added the label Needs rebase on Sep 13, 2018
-
configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx 92af71cea9
-
Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled a2a04a5abb
- luke-jr force-pushed on Sep 13, 2018
- DrahtBot removed the label Needs rebase on Sep 13, 2018
- DrahtBot cross-referenced this on Sep 21, 2018 from issue build: Add MSVC project files for bitcoin-wallet-tool by ken2812221
- DrahtBot cross-referenced this on Sep 21, 2018 from issue WIP: Add wallet tool test by promag
-
DrahtBot commented at 1:27 PM on September 21, 2018: contributor
<!--e57a25ab6845829454e8d69fc972939a-->Reviewers, this pull request conflicts with the following ones:
- #14284 (build: Add MSVC project files for bitcoin-wallet-tool by ken2812221)
- #14283 (WIP: Add wallet tool test by promag)
- #13926 ([Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot cross-referenced this on Sep 24, 2018 from issue tests: Remove unused testing code by practicalswift
-
MarcoFalke commented at 8:42 PM on September 24, 2018: member
utACK the bugfix. Didn't look at the first commit.
-
theuni commented at 8:30 PM on September 26, 2018: member
Seems a bit unnecessary, but I can't come up with a justifiable reason not to. -0 on the concept.
The changes themselves look sane, though. utACK a2a04a5abb347d52b3ef473f7c80c3c0ffc67a2f.
-
ryanofsky commented at 3:02 PM on September 27, 2018: contributor
utACK a2a04a5abb347d52b3ef473f7c80c3c0ffc67a2f both commits. I think configuration options like this are useful so you can choose the components you need in a set-and-forget config step, and then use normal
make,make install, andmake checkcommands.A previous comment (https://github.com/bitcoin/bitcoin/pull/5618#issuecomment-88454412) seemed to suggest that these autoconf options are useless because you could alternately run commands like
make -C src bitcoin-txto selectively build components. But that's cumbersome and unreliable and also doesn't work with build actions like "make check" and "make install".Only minor suggestion I'd make is to rephrase "Make it possible to build only one of bitcoin-cli or bitcoin-tx" commit description so it doesn't sound like these are exclusive options. When I first saw this this PR I thought it was going to disallow building both tools at the same time.
- MarcoFalke merged this on Sep 27, 2018
- MarcoFalke closed this on Sep 27, 2018
- MarcoFalke referenced this in commit b88dd7c2db on Sep 27, 2018
- ryanofsky cross-referenced this on Sep 27, 2018 from issue Multiprocess bitcoin by ryanofsky
- Bushstar cross-referenced this on Oct 11, 2018 from issue Updates from bitcoin/master by Bushstar
- deadalnix referenced this in commit a7ca467d91 on Apr 17, 2020
- ftrader referenced this in commit 4487044f26 on Aug 17, 2020
- pravblockc referenced this in commit 5d1533d938 on Jul 28, 2021
- bitcoin locked this on Sep 8, 2021
