doc: include arg -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON for cmake #1790

pull kevkevinpal wants to merge 1 commits into bitcoin-core:master from kevkevinpal:doc_useExternalDefaultCallbacks changing 1 files +2 −1
  1. kevkevinpal commented at 3:18 AM on December 19, 2025: contributor

    Motivation

    This is motivated by this comment #1778#pullrequestreview-3578687144

    Rationale

    It makes sense to add documentation on how to configure for CMake. I can reword if other wording is preferred

  2. in include/secp256k1.h:353 in beaf41cd62 
     348 | @@ -349,7 +349,8 @@ SECP256K1_API void secp256k1_context_destroy(
 349 |   *  writes the message to stderr and calls abort. This default callback can be
 350 |   *  replaced at link time if the preprocessor macro
 351 |   *  USE_EXTERNAL_DEFAULT_CALLBACKS is defined, which is the case if the build
 352 | - *  has been configured with --enable-external-default-callbacks. Then the
 353 | + *  has been configured with --enable-external-default-callbacks or 
 354 | + *  -DUSE_EXTERNAL_DEFAULT_CALLBACKS=1. Then the
    hebasto commented at 10:43 AM on December 19, 2025: 
     *  -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON. Then the
    real-or-random commented at 2:42 PM on December 19, 2025:

    Maybe say "with --enable-external-default-callbacks (GNU Autotools) or -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON (CMake)."

    kevkevinpal commented at 2:52 PM on December 19, 2025:

    Thanks! I updated to your suggestion in 0406cfc

  3. real-or-random added the label user-documentation on Dec 19, 2025
  4. real-or-random added the label tweak/refactor on Dec 19, 2025
  5. doc: include arg -DUSE_EXTERNAL_DEFAULT_CALLBACKS=1 for cmake 0406cfc4d1
  6. kevkevinpal force-pushed on Dec 19, 2025
  7. hebasto approved
  8. hebasto commented at 5:06 PM on December 19, 2025: member

    ACK 0406cfc4d1d414bbc806757bb42e540bf0d8a0c1.

    The PR title has to be updated as well.

  9. kevkevinpal renamed this:
    doc: include arg -DUSE_EXTERNAL_DEFAULT_CALLBACKS=1 for cmake
    doc: include arg -DSECP256K1_USE_EXTERNAL_DEFAULT_CALLBACKS=ON for cmake
    on Dec 19, 2025
  10. real-or-random approved
  11. real-or-random commented at 7:50 PM on December 19, 2025: contributor

    ACK 0406cfc4d1d414bbc806757bb42e540bf0d8a0c1

  12. real-or-random merged this on Dec 19, 2025
  13. real-or-random closed this on Dec 19, 2025
  14. Eunovo referenced this in commit b065787ddb on Jan 19, 2026
  15. fanquake referenced this in commit c4c4e04ca1 on Jan 26, 2026
  16. fanquake referenced this in commit 2fccbea3c8 on Jan 27, 2026
  17. fjahr referenced this in commit 182197f98a on Jan 29, 2026
  18. fjahr referenced this in commit ea9a84ab3c on Jan 31, 2026
  19. fjahr referenced this in commit 23c2527f12 on Feb 8, 2026
  20. Sjors referenced this in commit d5660d3a13 on Feb 16, 2026
  21. github-actions[bot] referenced this in commit c3f80fff5f on Mar 1, 2026
  22. github-actions[bot] referenced this in commit 4aeff8400e on Mar 1, 2026
  23. github-actions[bot] referenced this in commit 5f15eb0c55 on Mar 1, 2026
  24. 0x000000000019d6689c085ae165831e934ff76 referenced this in commit d54574beca on Mar 2, 2026
  25. csjones referenced this in commit fb3e16af04 on Mar 2, 2026
  26. real-or-random referenced this in commit 459eab20f2 on Mar 3, 2026
  27. vmta referenced this in commit 1ddc2f947f on Apr 26, 2026
  28. vmta referenced this in commit 56c40fe100 on Apr 27, 2026
Contributors
kevkevinpalhebastoreal-or-random
Labels
user-documentationtweak/refactor
Linked (view graph)
#1778 doc/bench: Added cmake build options to bench error messages
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:52 UTC