doc/bench: Added cmake build options to bench error messages #1778

Motivation

I wanted to try and run the benchmarking scripts and I noticed the recovery benchmark in bench.c. I wanted to run but I was using cmake and the error message telling me to use ./configure -enable-module-recovery wasn't sufficient.

I figure rather than forcing users to look into the CMakeLists.txt file or anywhere else we should add this to the output

Solution

I appended to the message to include the -DSECP256K1_ENABLE_MODULE_...=ON in the message.

Thanks for spotting this. Maybe a simpler fix (which will be easier to maintain in the future) is to remove this line (or simply refer to the README).

Thanks for spotting this. Maybe a simpler fix (which will be easier to maintain in the future) is to remove this line (or simply refer to the README).

Sounds good I pushed 3b5b03f to replace the message with this instead:

"See README.md for configuration instructions.\n\n"

let me know if this looks good, I can reword or simply delete the print if that is wanted

utACK 3b5b03f30169903baae7f365cff3137a371a9a8d

ACK 3b5b03f30169903baae7f365cff3137a371a9a8d, I have reviewed the code and it looks OK.

Another PR might also improve this comment:https://github.com/bitcoin-core/secp256k1/blob/5c75183344585baee5de74c771099d13613bf7dc/include/secp256k1.h#L352