Remove legacy BIP70 merchant name from tx details window #970

pull maflcko wants to merge 1 commits into bitcoin-core:master from maflcko:2610-gui-less-bugs changing 2 files +5 −41
  1. maflcko commented at 11:39 AM on October 28, 2026: contributor

    BIP70 is now dead for roughly half a decade. There is no need to print the merchant name in the tx details window, so remove that feature.

    The parser has no tests, nor fuzzing, so removing it will likely also fix some parsing issues with corrupt data.

  2. DrahtBot commented at 11:39 AM on October 28, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK l0rinc

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #bitcoin/bitcoin/36033 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36033.svg"></sub> ([wip,nomerge,rfc] build: Require C++23 compiler by maflcko)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. Remove legacy BIP70 merchant name from tx details window fa917ddcb1
  4. maflcko force-pushed on Oct 28, 2026
  5. DrahtBot added the label CI failed on Oct 28, 2026
  6. maflcko commented at 11:46 AM on October 28, 2026: contributor

    Obviously no rush to remove this ~dead code, but it would be nice to have it in the next release, to make it easier to review the code for real bugs.

  7. l0rinc commented at 12:03 PM on October 28, 2026: contributor

    lightweight code review ACK fa917ddcb1c7a2612dd8e57c3ef75e443cc8a962

  8. DrahtBot removed the label CI failed on Oct 28, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 09:48 UTC