qt: Fix multi-line label display in debug console Information panel #967

pull RandyMcMillan wants to merge 1 commits into bitcoin-core:master from bitcoincore-dev:1846/970227/279678/dcfb1b76fd/6a98f051ed-debug-console-handle-wordwrap changing 1 files +21 −13
  1. RandyMcMillan commented at 8:43 PM on October 6, 2026: contributor

    No description provided.

  2. DrahtBot renamed this:
    qt: Fix multi-line label display in debug console Information panel
    qt: Fix multi-line label display in debug console Information panel
    on Oct 6, 2026
  3. DrahtBot commented at 8:43 PM on October 6, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    Concept ACK Sjors
    Stale ACK jpk68

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. RandyMcMillan commented at 8:51 PM on October 6, 2026: contributor

    I left unsquashed for reviewer convienence

  5. in src/qt/forms/debugwindow.ui:430 in f3be683dcf
     426 | @@ -427,6 +427,9 @@
     427 |           <property name="spacing">
     428 |            <number>3</number>
     429 |           </property>
     430 | +         <property name="leftMargin">
    


    RandyMcMillan commented at 8:56 PM on October 6, 2026:

    this ensures the "Open" button for debug.log floats to right

  6. in src/qt/forms/debugwindow.ui:480 in 1a789e0207 outdated
     475 | -           <width>20</width>
     476 | -           <height>40</height>
     477 | -          </size>
     478 | -         </property>
     479 | -        </spacer>
     480 | -       </item>
    


    RandyMcMillan commented at 8:59 PM on October 6, 2026:

    commit f3be683dcf80c7b6bb5eded6225923f6e00a1c11 is a simpler way to accomplish the same layout and doesn't force additional padding at the bottom of the layout.

  7. RandyMcMillan commented at 9:33 PM on October 6, 2026: contributor

    when signet appended to datadir layout issue becomes more obvious.

    https://github.com/bitcoin/bitcoin

    <img width="615" height="558" alt="Screenshot 2026-10-06 at 5 32 01 PM" src="https://github.com/user-attachments/assets/707d9a32-5537-471e-b5dc-09cb4b0b47cf" />

  8. jpk68 approved
  9. jpk68 commented at 4:46 PM on October 21, 2026: contributor

    ACK 1a789e02077772542e296ba5db2e6fc2c54c6754

  10. Sjors commented at 6:13 AM on October 28, 2026: member

    Concept ACK

    I was able to reproduce the issue on Linux (headless) and macOS (actual desktop), and this PR fixes it.

    Code review 1a789e02077772542e296ba5db2e6fc2c54c6754

    Please squash the commits. Your pull request title makes for a good commit message. The commit message body can explain the motivation and changes in more detail.

    Make sure that you, or your agent, check if each change is actually necessary. My brief testing suggests f3be683dcf isn't.

  11. maflcko commented at 11:18 AM on October 29, 2026: contributor

    ~0 Seems trivial to work around by just increasing the window as the user. Given the QML gui, should this be closed?

  12. qt: Fix multi-line label display in debug console Information panel 6e7d5ddff3
  13. RandyMcMillan force-pushed on Oct 29, 2026
  14. RandyMcMillan commented at 3:07 PM on October 29, 2026: contributor

    6e7d5ddff3bf7217ff3c72457ec8f260ea1b5c07 - remove commit f3be683dcf80c7b6bb5eded6225923f6e00a1c11 per @Sjors suggestion and squash.

  15. RandyMcMillan commented at 3:28 PM on October 29, 2026: contributor

    @maflcko,

    I think it is worth while to maintain this gui implementation until an "official" sun setting is announced.

    It has been a while since I have checked out the QML progress - I am sure it is progressing - but I don't anticipate the QML gui being merged until the full modularization and separation of the gui all together.

    There are concerns related to the proper "sandboxing" of the Qt QML engine.

    <img width="694" height="410" alt="Screenshot 2026-10-29 at 11 26 49 AM" src="https://github.com/user-attachments/assets/3b39ca5c-ae1d-43b2-8e9f-2b6da8a06150" />

  16. RandyMcMillan requested review from jpk68 on Oct 29, 2026
  17. maflcko commented at 4:12 PM on October 29, 2026: contributor

    It has been a while since I have checked out the QML progress - I am sure it is progressing - but I don't anticipate the QML gui being merged until the full modularization and separation of the gui all together.

    Same, but IIUC there was a recent update on the QML progress (check the last IRC meeting). So the QML gui may be available in 33.x. Even if it only makes it only later (e.g. 34.x), I still think the current gui should be frozen. This isn't a regression here, so just leaving this unfixed shouldn't make anything worse.

    I mostly think if the QML gui is planned, all efforts should move toward that. Spending more time on the old gui will just delay the new gui.

    If you think the new gui should not happen, or if you think there are weak spots, it would be good to raise those points or better: fix them.

  18. DrahtBot added the label CI failed on Oct 29, 2026
  19. RandyMcMillan commented at 11:12 PM on October 29, 2026: contributor

    @maflcko

    I actually stood down - I wanted to see what all those grant dollars would produce...

    I am terribly disappointed...

    Maybe somebody that gets paid to work on the qml gui can take this up...

    https://github.com/bitcoin-core/gui-qml/pull/1055


jpk68

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 09:48 UTC