Added test coverage for qt gui#901 console history filter #910

pull waketraindev wants to merge 1 commits into bitcoin-core:master from waketraindev:2025-11-gui-filtered-qt-tests changing 1 files +7 −1
  1. waketraindev commented at 5:40 PM on November 6, 2025: contributor

    Add test coverage for the QT rpc console updated filtered commands in gui#901

  2. DrahtBot commented at 5:41 PM on November 6, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK pablomartin4btc, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #909 (Prevent re-execution of sensitive commands from console history by waketraindev)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. waketraindev marked this as ready for review on Nov 6, 2025
  4. in src/qt/test/rpcnestedtests.cpp:1 in 0e9f330bdc outdated
    pablomartin4btc commented at 4:50 PM on November 12, 2025:

    nit: since you are there please update the copyright (2016-present)...

    // Copyright (c) 2016-2021 The Bitcoin Core developers

  5. pablomartin4btc commented at 4:54 PM on November 12, 2025: contributor

    tACK 0e9f330bdc9435a1ebea229eba58d434b07ab3aa

  6. DrahtBot added the label CI failed on Nov 12, 2025
  7. DrahtBot removed the label CI failed on Nov 12, 2025
  8. in src/qt/test/rpcnestedtests.cpp:1 in d32cf0aa52 
       0 | @@ -1,4 +1,4 @@
   1 | -// Copyright (c) 2016-2021 The Bitcoin Core developers
   2 | +// Copyright (c) 2016-2025 The Bitcoin Core developers
    pablomartin4btc commented at 10:42 PM on November 12, 2025:

    so we don't have to update it every time...

    // Copyright (c) 2016-present The Bitcoin Core developers
    waketraindev commented at 10:43 PM on November 12, 2025:

    Ah fixed, didn't think you meant present literally; sorry

  9. qt: Added test coverage for qt gui#901 console history filter 310e4979b3
  10. pablomartin4btc approved
  11. pablomartin4btc commented at 10:59 PM on November 13, 2025: contributor

    ACK 310e4979b36cbcf1e9e01dd90c14e2e9997343a0

  12. hebasto approved
  13. hebasto commented at 11:23 PM on November 18, 2025: member

    ACK 310e4979b36cbcf1e9e01dd90c14e2e9997343a0, tested on Fedora 42 by reverting 4e352efa2ce756c668664486c99d003eef530e0c.

  14. hebasto merged this on Nov 18, 2025
  15. hebasto closed this on Nov 18, 2025
  16. waketraindev deleted the branch on Nov 18, 2025
  17. waketraindev restored the branch on Nov 18, 2025
  18. waketraindev deleted the branch on Nov 19, 2025
  19. stringintech referenced this in commit 52fffa1e5d on Nov 24, 2025
  20. alexanderwiederin referenced this in commit 7334556a3f on Dec 1, 2025
  21. yuvicc referenced this in commit 4a77a3b8eb on Dec 16, 2025
  22. stickies-v referenced this in commit 9fa736f8e4 on Jan 22, 2026
Contributors
waketraindevDrahtBotpablomartin4btchebasto
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-25 07:20 UTC