This PR split from bitcoin/bitcoin#26705 and contains only changes in src/qt.
Effectively, it fixes the clang-tidy's modernize-use-default-member-init errors, and forces clang-tidy checks for all headers in the src/qt directory.
clang-tidy: Force checks for headers in `src/qt` #686
pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:221216-tidy changing 62 files +109 −167-
hebasto commented at 11:59 AM on December 16, 2022: member
-
69eacf2c5e
clang-tidy, qt: Fix `modernize-use-default-member-init` in headers
See https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-default-member-init.html
-
clang-tidy, qt: Force checks for headers in `src/qt` 7b7cd11244
-
DrahtBot commented at 11:59 AM on December 16, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK jarolrod If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #684 (Improve 'Requested Payments History' Multiselect by john-moffett)
- #662 (Fix transaction view/table by luke-jr)
- #658 (Intro: Never change the prune checkbox after the user has touched it by luke-jr)
- #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)
- #497 (Enable users to configure their monospace font specifically by luke-jr)
- #152 (Initialise DBus notifications in another thread by luke-jr)
- #bitcoin/bitcoin/26858 (wallet: Use defined purposes instead of inlining by aureleoules)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- maflcko added the label Refactoring on Dec 17, 2022
-
- hebasto renamed this:
clang-tidy, qt: Force checks for headers in `src/qt`
clang-tidy: Force checks for headers in `src/qt`
on Dec 20, 2022 - jarolrod approved
-
jarolrod commented at 5:38 AM on January 17, 2023: contributor
ACK 7b7cd112444b996a8ae6a6edfed00bcee67546c8
To confirm the correctness of the changes, I dropped the first commit and ran the CI locally. The log for the tidy task states what to fix, I went through this, painstakingly, for a long time, and arrived to the same diff as this PR.
Also did some light testing of the binary with these changes. Also, CI is happy.
- hebasto merged this on Jan 17, 2023
- hebasto closed this on Jan 17, 2023
- sidhujag referenced this in commit 418de2bf6e on Jan 17, 2023
- bitcoin-core locked this on Jan 17, 2024
Labels