Inline CTxInWitness inside CTxIn #8589

pull sipa wants to merge 1 commits into bitcoin:master from sipa:segwitinlinepain changing 18 files +96 −176

sipa commented at 11:31 AM on August 25, 2016: member

This is a rebase of #8452 on top of #8580.
sipa cross-referenced this on Aug 25, 2016 from issue Code simplification: inline CTxInWitness inside CTxIn by sipa
jonasschnelli added the label Refactoring on Aug 29, 2016
sipa force-pushed on Sep 5, 2016
sipa force-pushed on Sep 19, 2016
sipa force-pushed on Oct 2, 2016
sipa cross-referenced this on Oct 29, 2016 from issue Make CTransaction actually immutable by sipa
fanquake commented at 12:28 PM on November 6, 2016: member

This needs a rebase.
sipa commented at 2:03 AM on November 7, 2016: member

@fanquake Planning to rebase this after #8580, which I'll rebase after #9039.
sipa force-pushed on Nov 13, 2016
sipa force-pushed on Nov 13, 2016
sipa force-pushed on Nov 13, 2016
sipa commented at 12:19 AM on November 14, 2016: member

Rebased on top of the new #8580.
sipa force-pushed on Nov 15, 2016
sipa cross-referenced this on Nov 16, 2016 from issue Make CBlock a vector of shared_ptr of CTransactions by sipa
sipa force-pushed on Nov 20, 2016
sipa force-pushed on Nov 22, 2016
sdaftuar cross-referenced this on Nov 23, 2016 from issue Improve DisconnectTip performance by sdaftuar
sipa force-pushed on Nov 30, 2016
sipa force-pushed on Dec 1, 2016
sipa force-pushed on Dec 1, 2016
sipa force-pushed on Dec 1, 2016
sipa force-pushed on Dec 3, 2016
Move CTxInWitness inside CTxIn f6fb7acda4
sipa force-pushed on Dec 5, 2016
sipa renamed this:
~~Inline CTxInWitness inside CTxIn (on top of #8580)~~
Inline CTxInWitness inside CTxIn
on Dec 5, 2016
sipa commented at 8:26 AM on December 5, 2016: member

Rebased now #8580 is merged. Removes 80 lines of code!
laanwj commented at 12:24 PM on December 8, 2016: member

Testing #8589 #9283 #9288 #9589 on a reasonably busy public node.
sipa commented at 5:53 PM on December 9, 2016: member

I am curious what this myhtical #9589 is!
gmaxwell commented at 8:23 PM on December 12, 2016: contributor

ACK
paveljanik commented at 9:58 PM on December 12, 2016: contributor

Compiles cleanly utACK https://github.com/bitcoin/bitcoin/pull/8589/commits/f6fb7acda4aefd01b8ef6cd77063bfc0c4f4ab36
laanwj cross-referenced this on Dec 14, 2016 from issue Node crashed with assertion failure in network code by laanwj
laanwj commented at 12:56 PM on December 21, 2016: member

I am curious what this myhtical #9589 is!

#9289, sorry :)
laanwj commented at 1:00 PM on December 21, 2016: member

Slightly-tested ACK f6fb7ac
laanwj merged this on Dec 21, 2016
laanwj closed this on Dec 21, 2016
laanwj referenced this in commit e8cfe1ee2d on Dec 21, 2016
morcos commented at 2:55 PM on December 21, 2016: member

so much better thanks!
sipa cross-referenced this on Dec 22, 2016 from issue A few more CTransactionRef optimizations by sipa
sipa cross-referenced this on Aug 24, 2018 from issue Disallow extended encoding for non-witness transactions by sipa
MarcoFalke referenced this in commit c65c77c721 on Apr 25, 2019
sidhujag referenced this in commit fd6ff32bc6 on Apr 27, 2019
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8452 Code simplification: inline CTxInWitness inside CTxIn #8580 Make CTransaction actually immutable #9039 Various serialization simplifcations and optimizations #9125 Make CBlock a vector of shared_ptr of CTransactions #9208 Improve DisconnectTip performance #9283 A few more CTransactionRef optimizations #9288 Fix a bug if the min fee is 0 for FeeFilterRounder #9289 net: drop boost::thread_group #9348 Node crashed with assertion failure in network code #14039 Disallow extended encoding for non-witness transactions #24350 Primitives: Correct CTransaction deserialization docstring