[Trivial] Do not shadow members in dbwrapper #8467

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160805_Wshadow_dbwrapper changing 1 files +6 −6
  1. paveljanik commented at 7:21 PM on August 5, 2016: contributor

    This is a followup to #8105.

    dbwrapper.h code shadows some members. Fixes use underscore prefix (I also migrated piterIn into _piter to follow this style).

    For review, compare binaries or compile with -Wshadow and compare complete logs.

  2. Do not shadow members in dbwrapper 4a35e0f34c
  3. MarcoFalke commented at 7:28 PM on August 5, 2016: member

    Is there an advantage to create multiple pulls for this? If the review is mechanic, it would help to have as few as possible.

  4. paveljanik commented at 7:49 PM on August 5, 2016: contributor

    I'm trying to group similar changes. Reviewing 42 changed files at once is not easy and it is very time consuming to do it right. I prefer tackling the task in steps/groups.

    This particular change group of one file only unfortunately.

  5. theuni commented at 8:12 PM on August 5, 2016: member

    ut ACK

  6. MarcoFalke commented at 9:42 AM on August 6, 2016: member

    utACK 4a35e0f (Gives same binaries)

  7. jonasschnelli added the label Refactoring on Aug 8, 2016
  8. sipa commented at 5:39 AM on August 10, 2016: member

    utACK 4a35e0f34c0d1c2bbcae6d7b6d691fb0df946dfe

  9. sipa merged this on Aug 10, 2016
  10. sipa closed this on Aug 10, 2016

  11. sipa referenced this in commit 484312bda2 on Aug 10, 2016
  12. str4d cross-referenced this on Aug 28, 2017 from issue Bitcoin 0.12+ dbwrapper improvements by str4d
  13. codablock referenced this in commit 33c6e051c6 on Sep 19, 2017
  14. codablock referenced this in commit 55763949e3 on Sep 27, 2017
  15. codablock referenced this in commit ddf25fc2cf on Oct 12, 2017
  16. codablock referenced this in commit 94e01eb660 on Oct 23, 2017
  17. UdjinM6 referenced this in commit b8dca6b754 on Nov 8, 2017
  18. zkbot referenced this in commit 068e82e00a on Jan 15, 2018
  19. litecoinz-project referenced this in commit 64338392fa on Mar 15, 2018
  20. zkbot referenced this in commit 564119eb31 on Apr 3, 2018
  21. zkbot referenced this in commit 77669b952b on Apr 3, 2018
  22. random-zebra cross-referenced this on May 19, 2020 from issue [DB] Bitcoin 0.12-0.14 dbwrapper improvements by random-zebra
  23. random-zebra referenced this in commit 73d26f20e9 on May 27, 2020
  24. lyricidal cross-referenced this on Aug 27, 2021 from issue [Upstream] [DB] Bitcoin 0.12-0.14 dbwrapper improvements by lyricidal
  25. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-20 06:55 UTC