signal handling: fReopenDebugLog and fRequestShutdown should be type sig_atomic_t #8004

pull catilac wants to merge 1 commits into bitcoin:master from catilac:fix_signal_handler changing 3 files +7 −3

catilac commented at 4:47 AM on May 5, 2016: contributor

This allows access as an atomic variable in the presence of async interrupts.

See issue #7433 for more details fixes: #7433
laanwj added the label Bug on May 5, 2016
laanwj commented at 5:54 AM on May 5, 2016: member

I think you're missing signal.h include at the places you use the type.
catilac commented at 10:55 PM on May 8, 2016: contributor

@laanwj ahh you were right 👍
MarcoFalke commented at 7:09 AM on May 9, 2016: member

@catilac Mind to squash the commits?

laanwj commented at 8:52 AM on May 9, 2016: member

ACK after squash into one "atomic" commit E.g.

$ git checkout fix_signal_handler
$ git rebase -i 88b77c7
# set bottom two commits from 'pick' to 'squash', save and quit editor
$ git push -f

MarcoFalke cross-referenced this on May 9, 2016 from issue Add 'how to squash several fixup commits' to our coding guideline by MarcoFalke

fReopenDebugLog and fRequestShutdown should be type sig_atomic_t

This allows access as an atomic variable in the presence
of async interrupts.

See issue #7433 for more details
fixes: #7433

326231611b

catilac commented at 3:22 PM on May 9, 2016: contributor

Ah right! Done and done.
sipa commented at 7:29 PM on May 9, 2016: member

utACK 326231611bda6808b579ab7286e471c36f62e98c
fanquake commented at 5:39 AM on May 10, 2016: member

utACK 3262316
dcousens commented at 3:15 AM on May 11, 2016: contributor

utACK 3262316
laanwj merged this on May 12, 2016
laanwj closed this on May 12, 2016
laanwj referenced this in commit 2efe38b832 on May 12, 2016
elfring commented at 1:00 PM on May 12, 2016: none

Thanks for your small source code improvement.
sipa cross-referenced this on May 28, 2016 from issue Include signal.h for sig_atomic_t in WIN32 by sipa
bitcartel cross-referenced this on Oct 25, 2016 from issue Upstream 8123 race condition by bitcartel
zkbot referenced this in commit 11ce636a9d on Oct 25, 2016
codablock referenced this in commit 7a4f1329f9 on Sep 16, 2017
codablock referenced this in commit 89077fc012 on Sep 19, 2017
codablock referenced this in commit 26f07f835c on Dec 21, 2017
bitcoin locked this on Sep 8, 2021

Contributors

Labels