Refactor script tests #7818

pull sipa wants to merge 6 commits into bitcoin:master from sipa:refactorscriptests changing 6 files +2128 −2124

sipa commented at 2:16 PM on April 5, 2016: member
Included is:
- Fix JSON pretty printing for script test autogeneration (which was broken by univalue, which has different pretty printing).
- Fix autogeneration of OP_NOP (which generated invalid hex)
- Some of the included tests were not actually testing what they were intended to test.
- Merge script_valid and script_invalid into one file (JSON format change)
Fix JSON pretty printing in script_tests c7c664191f
Fix formatting of NOPs for generated script tests d03e46625a

Fix some misconstructed tests

They claimed to be testing P2SH scripts with non-push scriptSigs, but
1) they were not enabling P2SH
2) they have push-only scriptSigs

Fix this, and add a few more related cases.

269281b7cc

Make script_error a mandatory 4th field for script_tests 76da761351
Get rid of expect in script_tests as it's implied by scripterror 009b503792
Merge script_valid and script_invalid tests dde46d3ae1
laanwj added the label Tests on Apr 5, 2016
laanwj commented at 3:43 PM on April 5, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/7818/commits/dde46d3ae1de18700e089bc1861cf1e18649dc5d
sipa cross-referenced this on Apr 10, 2016 from issue [0.12 backport] script_tests improvements from master and #7818 by sipa
dcousens commented at 6:51 AM on April 11, 2016: contributor

concept ACK, once-over utACK dde46d3. I haven't checked any of the test fixtures themselves to ensure they are as they were (or improved as mentioned).
laanwj merged this on Apr 14, 2016
laanwj closed this on Apr 14, 2016
laanwj referenced this in commit 3911a0a1b7 on Apr 14, 2016
MarcoFalke referenced this in commit 51a55409a0 on May 4, 2016
MarcoFalke referenced this in commit e3a9ce9c94 on May 4, 2016
nomnombtc referenced this in commit 03bee8d04e on Nov 12, 2016
nomnombtc referenced this in commit 62341e597a on Nov 12, 2016
nomnombtc referenced this in commit fdaa711d58 on Nov 13, 2016
sickpig referenced this in commit 58f48e3bbd on Nov 14, 2016
str4d cross-referenced this on Mar 5, 2021 from issue Backport bloom filter improvements by str4d
zkbot referenced this in commit be459619a8 on Mar 5, 2021
zkbot referenced this in commit 78de0cdf46 on Apr 15, 2021
furszy cross-referenced this on Aug 4, 2021 from issue [Test] BIP62 rule 6 added + script tests updates by furszy
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7854 [0.12 backport] script_tests improvements from master and #7818