build: fix osx+homebrew+qt5 builds #5026

pull theuni wants to merge 2 commits into bitcoin:master from theuni:osx-brew-qt5 changing 3 files +49 −9

theuni commented at 11:28 PM on October 1, 2014: member

qt5 is a bottled recipe in Homebrew to avoid conflicting with qt4. These changes help us compensate for that.

Also, Homebrew's qt5 build drags in all of qt5, way more than our minimal build in depends/. Add to the current filter-list to avoid packaging all that cruft.

build: Fix OSX build when using Homebrew and qt5

Qt5 is bottled, so configure won't find it without some help. Use
brew to find out its prefix.

Also, qt5 added the host_bins variable to pkg-config, use it.

9fedafba4b

build: macdeploy: filter out irrelevant qt5 frameworks and dylibs dd367ff8c9
theuni commented at 11:42 PM on October 1, 2014: member

Paging @gavinandresen. This should fix your build.
laanwj added the label Build system on Oct 2, 2014
laanwj added the label Mac on Oct 2, 2014
gavinandresen commented at 4:02 PM on October 2, 2014: contributor
ACK, I can build both qt4 and qt5, and a code-signed macdeployqtplus works with the qt5 build.

Just FYI: macdeployqtplus doesn't work with the qt4 build; codesign is upset that there is a Resources/ folder at the top-level of Bitcoin-Qt.app/Contents/Frameworks/QtGui.framework
```
dist/Bitcoin-Qt.app: unsealed contents present in the root directory of an embedded framework
```
gavinandresen merged this on Oct 2, 2014
gavinandresen closed this on Oct 2, 2014
gavinandresen referenced this in commit 4b73b758a3 on Oct 2, 2014
laanwj commented at 5:37 PM on October 2, 2014: member

@theuni This does not apply as-is to 0.9.3 branch (too many changes to build system since). If this intended for the next 0.9.x as well, can you do a pull against that?
theuni commented at 6:51 PM on October 2, 2014: member

@gavinandresen Thanks for verifying. I'll see if there's a quick/easy fix for qt4 (and if any qt5 build scenarios could end up with the same issue). I don't think it's worth too much effort though, since realistically we won't be signing any more qt4 binaries. @laanwj Will do.
theuni cross-referenced this on Oct 3, 2014 from issue build: Fix OSX build when using Homebrew and qt5 by theuni
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5039 build: Fix OSX build when using Homebrew and qt5