[cleanup] leveldbwrapper becomes more generic 'dbwrapper' module #6873

pull jgarzik wants to merge 3 commits into bitcoin:master from jgarzik:2015_dbwrapper changing 7 files +85 −89

jgarzik commented at 1:40 AM on October 23, 2015: contributor

See individual commits for step-by-step transformation.

This originates from the conversion from leveldb to sqlite. Some operations in the wrapper class were not needed, and the 'leveldb' moniker itself is not needed as this is really bitcoin's generic backend database glue layer.

The follow-on changes that build on top of this preparatory step can be seen at https://github.com/jgarzik/bitcoin/tree/2015_sqlite
leveldbwrapper: Remove unused .Prev(), .SeekToLast() methods
Also, trim trailing whitespace.
6ec4b7eb20
leveldbwrapper symbol rename: Remove "Level" from class, etc. names 8587b23038
leveldbwrapper file rename to dbwrapper.* 3795e8152b
jmcorgan commented at 2:06 AM on October 23, 2015: contributor

ACK
dcousens commented at 2:14 AM on October 23, 2015: contributor

ACK. @jgarzik any thoughts on whether the path argument is relevant to the API? It is relevant to the current underlying implementation (leveldb), but if the idea is to allow expansion to other data models, its likely it won't always be relevant.
btcdrak commented at 6:14 AM on October 23, 2015: contributor

utACK
jonasschnelli commented at 6:26 AM on October 23, 2015: contributor

Nice! UtACK
MarcoFalke commented at 6:29 AM on October 23, 2015: member

utACK
pstratem commented at 6:34 AM on October 23, 2015: contributor

utACK
laanwj added the label Refactoring on Oct 23, 2015
laanwj commented at 8:32 AM on October 23, 2015: member

Great idea. concept ACK (only quickly skimmed over it)
jgarzik merged this on Oct 23, 2015
jgarzik closed this on Oct 23, 2015
jgarzik referenced this in commit 46f74379b8 on Oct 23, 2015
veikkoeeva cross-referenced this on Jan 7, 2017 from issue ZCash build system improvements to leverage native tooling and other (native) assets where applicable by veikkoeeva
str4d cross-referenced this on Aug 1, 2017 from issue Fixes for GCC 7 by bhjortsberg
str4d cross-referenced this on Aug 28, 2017 from issue Bitcoin 0.12+ dbwrapper improvements by str4d
dagurval cross-referenced this on Oct 27, 2017 from issue [cleanup] leveldbwrapper becomes more generic 'dbwrapper' module by dagurval
zkbot referenced this in commit 068e82e00a on Jan 15, 2018
litecoinz-project referenced this in commit f9cf85eb37 on Mar 15, 2018
zkbot referenced this in commit 564119eb31 on Apr 3, 2018
zkbot referenced this in commit 77669b952b on Apr 3, 2018
random-zebra cross-referenced this on May 19, 2020 from issue [DB] Bitcoin 0.12-0.14 dbwrapper improvements by random-zebra
random-zebra referenced this in commit 73d26f20e9 on May 27, 2020
lyricidal cross-referenced this on Aug 27, 2021 from issue [Upstream] [DB] Bitcoin 0.12-0.14 dbwrapper improvements by lyricidal
bitcoin locked this on Sep 8, 2021

Contributors

Labels