[patch] address/label search tweak #641

The following patch allows for filtering addresses and labels by searching for the typed string anywhere, not just at the beginning. Trivial to test, and it helps a little with usability:

--- src/qt/transactionfilterproxy.cpp.old 2011-11-18 10:56:12.764263766 +0200 +++ src/qt/transactionfilterproxy.cpp 2011-11-18 10:59:07.064263768 +0200 @@ -35,7 +35,8 @@ return false; if(datetime < dateFrom || datetime > dateTo) return false;

• if(!address.startsWith(addrPrefix) && !label.startsWith(addrPrefix))
• //if(!address.startsWith(addrPrefix) && !label.startsWith(addrPrefix))
• if (!address.contains(addrPrefix, Qt::CaseInsensitive) && !label.contains(addrPrefix, Qt::CaseInsensitive)) return false; if(amount < minAmount) return false;

Sounds useful!

Can you please delete the commented line? Op 18 nov. 2011 10:14 schreef "Ovidiu Constantin" < reply@reply.github.com> het volgende:

The following patch allows for filtering addresses and labels by searching for the typed string anywhere, not just at the beginning. Trivial to test, and it helps a little with usability:

--- src/qt/transactionfilterproxy.cpp.old 2011-11-18 10:56: 12.764263766 +0200 +++ src/qt/transactionfilterproxy.cpp 2011-11-18 10:59:07.064263768 +0200 @@ -35,7 +35,8 @@ return false; if(datetime < dateFrom || datetime > dateTo) return false;

• if(!address.startsWith(addrPrefix) && !label.startsWith(addrPrefix))
• //if(!address.startsWith(addrPrefix) && !label.startsWith(addrPrefix))
• if (!address.contains(addrPrefix, Qt::CaseInsensitive) && !label.contains(addrPrefix, Qt::CaseInsensitive)) return false; if(amount < minAmount) return false;

---

Reply to this email directly or view it on GitHub: #641

Sure, here's the new diff:

--- src/qt/transactionfilterproxy.cpp.old 2011-11-18 10:56:12.764263766 +0200 +++ src/qt/transactionfilterproxy.cpp 2011-11-18 12:25:46.674263828 +0200 @@ -35,7 +35,7 @@ return false; if(datetime < dateFrom || datetime > dateTo) return false;

• if(!address.startsWith(addrPrefix) && !label.startsWith(addrPrefix))
• if (!address.contains(addrPrefix, Qt::CaseInsensitive) && !label.contains(addrPrefix, Qt::CaseInsensitive)) return false; if(amount < minAmount) return false;

I thought you'd submitted a pull request, hence my question to fix the comment line. Heh blame my phone.

It's been applied, thanks.

No problem, I was too lazy to do it properly on github :)

O.

On Thu, Nov 24, 2011 at 9:22 PM, Wladimir J. van der Laan reply@reply.github.com wrote:

I thought you'd submitted a pull request, hence my question to fix the comment line. Heh blame my phone.

It's been applied, thanks.

---

Reply to this email directly or view it on GitHub: #641 (comment)

Ovidiu Constantin ovidiu@mybox.ro http://blog.mybox.ro/  *  http://twitter.com/ovidiusoft

Is this a (usability) bugfix, or new feature?

Usability fix. Previously, when you typed in the Address field, it matched just the beginning of the address/label. The fix matches any part and is case insensitive. So if you have a label "Pool: Eligius", you can type "eli".

... ok, that's spooky: how do you know what my Eligius earnings label is named? O.O

Super powers! :)

On Fri, Nov 25, 2011 at 4:05 PM, Luke-Jr reply@reply.github.com wrote:

... ok, that's spooky: how do you know what my Eligius earnings label is named? O.O

---

Reply to this email directly or view it on GitHub: #641 (comment)