[29.x] Finalise 29.5 #36666

pull fanquake wants to merge 7 commits into bitcoin:29.x from fanquake:finalise_29_5 changing 19 files +111 −48

fanquake commented at 2:05 PM on October 26, 2026: member
Backports:
- #36665
- #36667
- #36669
fanquake added this to the milestone 29.5 on Oct 26, 2026
DrahtBot added the label Backport on Oct 26, 2026
DrahtBot commented at 2:05 PM on October 26, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36666
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36666.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36666#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK darosior, willcl-ark, sedited, l0rinc

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
build: bump version to v29.5 ebaa852b6f
doc: update manual pages for v29.5 7ffe1c903d
sock: align exception monitoring between poll() and select() backends
Github-Pull: #36665 Rebased-From: 1e0c407377034e9cbb4d52f1f534c06cdf202a36
b3526cf152
fanquake force-pushed on Oct 26, 2026
l0rinc approved
l0rinc commented at 6:06 PM on October 26, 2026: contributor

ACK 109b8fe0b1ee66cad88fcfb17a59c09add084e7d

Reviewed the cherry-pick manually and checked the remaining commits automatically. The patch matches upstream apart from the older RECV/SEND names.

Type	Reviewers
ACK	darosior, willcl-ark, sedited, l0rinc

net: enforce timeout interval for paused send peers

No need to waste a connection slot on a peer that is so slow to read as to not
drain our send buffer down to the 1MB threshold within 20 minutes.

Github-Pull: #36667
Rebased-From: cc2534cdf7b14d0f1a18928ebaab7f7fdd7e839e

02c76d5d5f

fanquake force-pushed on Oct 26, 2026
l0rinc commented at 6:44 PM on October 26, 2026: contributor

reACK ccf3c788858d5d167da23e71ee59bd50eac3379a

Reviewed the added #36667 cherry-pick, with the same clock and logging adaptations as v30.

flatfile: store position as a 64 bits integer

This is the last field that is only bounded by the usage callers make of it
(unlike the file number, for instance). Promoting it to a 64 bits integer also
does not change on-disk representation since we serialize positions as varints.
Therefore, widen them to prevent any possible future misuse.

Github-Pull: #36669
Rebased-From: 17556cb1f52fcbc807f65245101f72e8ec1573d8

5c99cb6745

fanquake force-pushed on Oct 26, 2026
fanquake marked this as ready for review on Oct 26, 2026
darosior commented at 8:04 PM on October 26, 2026: member

273560fc92b777437ee6e4f6f7c0e5bd8a6584bb says "Github-Pull: #3666" instead of #36669

flatfile: use 64-bit file positioning syscalls in Windows

Github-Pull: #36669
Rebased-From: 48092a9042d8fcfd6bb7ae5911a1d53b8746d546

b2994bd0f5

doc: update release notes for v29.5 dee8c7186f
fanquake force-pushed on Oct 26, 2026
darosior commented at 8:36 PM on October 26, 2026: member

ACK dee8c7186f26bfa1623b4d1cda77081292a8574e
DrahtBot requested review from l0rinc on Oct 26, 2026
willcl-ark approved
willcl-ark commented at 8:47 PM on October 26, 2026: member

ACK dee8c7186f26bfa1623b4d1cda77081292a8574e

Backports LGTM.
sedited approved
sedited commented at 9:02 PM on October 26, 2026: contributor

Reproduced ACK dee8c7186f26bfa1623b4d1cda77081292a8574e
l0rinc commented at 9:23 PM on October 26, 2026: contributor

reACK dee8c7186f26bfa1623b4d1cda77081292a8574e

#36669 cherry-pick also looks fine
fanquake merged this on Oct 26, 2026
fanquake closed this on Oct 26, 2026
fanquake deleted the branch on Oct 26, 2026
Sjors commented at 11:36 AM on October 27, 2026: member

ACK dee8c7186f26bfa1623b4d1cda77081292a8574e

I also reviewed the backported PRs.