rpc: wallet: Schedule mixed-case confTarget option deprecation #36488

1. 
   maflcko commented at 9:54 AM on October 9, 2026: member

   Since commit 91f6d2bc8ff4d4cd1b86daa370ec9d2d9662394d in 2020, the wallet accepts and documents conf_target for the fee bump RPC.

   So it seems time to cut the confusion and properly deprecate it with the next cycle.

2. DrahtBot added the label RPC/REST/ZMQ on Oct 9, 2026
3. 
   DrahtBot commented at 9:54 AM on October 9, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   External sites

   • Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36488
   • Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36488.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36488#author-ralph

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   ACK	fametrano

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #36387 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36387.svg">} (wallet: rpc: Deprecate encryptwallet RPC for encrypting existing wallets. by davidgumberg)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

4. maflcko added this to the milestone 33.0 on Oct 9, 2026
5. maflcko force-pushed on Oct 9, 2026
6. DrahtBot added the label CI failed on Oct 9, 2026
7. maflcko added the label Wallet on Oct 9, 2026
8. maflcko force-pushed on Oct 9, 2026
9. DrahtBot removed the label CI failed on Oct 9, 2026
10. maflcko force-pushed on Oct 16, 2026
11. rpc: wallet: Schedule mixed-case confTarget option deprecation fab22ac42e
12. maflcko force-pushed on Oct 20, 2026
13. 
    fametrano commented at 6:49 AM on October 25, 2026: none

    tACK fab22ac42e350d4b4481515fe8ba2a319a744389

    No test checks that confTarget still works under -deprecatedrpc=confTarget. The comment in rpc_deprecated.py asks that each deprecation tested there keep another functional test that still exercises it under the flag. wallet_bumpfee.py gains the flag, but its only confTarget call is the "should not both be set" error, so a change that broke confTarget behind the flag would still pass the tests. One bumpfee and one psbtbumpfee call with {"confTarget": 6} in that test would cover it.

    The rest matched. Without the flag, both RPCs return -32 for confTarget, alone or next to conf_target, before the txid is looked up. With the flag, confTarget bumps and the conflict error is unchanged. conf_target works either way, positional or named. The help and getopenrpcinfo list only conf_target.

    I measured this on regtest against a build of the head, with and without the flag, with calls sent through a client library I maintain. I can share the script and its output.

14. 
    maflcko commented at 9:03 AM on October 26, 2026: member

    No test checks that confTarget still works under -deprecatedrpc=confTarget.

    Your LLM-co-authored comment is just repeating what the Ralph LLM already said. There never was a test for this since 2020, the option was undocumented since then, so likely no user is using it. I don't think it makes sense to add a test for this now, given that such a test would be harder to review than the code change here by itself.

Milestone
33.0