PSBT: Make input/output `Merge()` methods return void #36168

pull nebula-21 wants to merge 1 commits into bitcoin:master from nebula-21:add-mergepsbt-coverage changing 2 files +6 −14
  1. nebula-21 commented at 6:02 PM on September 4, 2026: contributor

    PSBT input/output Merge() methods always return true unconditionally and have no failure paths. As a result, the return value checks in PartiallySignedTransaction::Merge() can never fail and are dead code. This makes the bool return type and [[nodiscard]] misleading.

    This PR changes both methods to return void and remove the return value checks. If at some point in the future the failure logic is needed, it can be introduced again. For now using void makes the current behavior easier to understand.

  2. PSBT: Make input/output `Merge()` methods return void 82deb69111
  3. DrahtBot added the label PSBT on Sep 4, 2026
  4. DrahtBot commented at 6:02 PM on September 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36168.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK achow101, polespinasa, sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. achow101 commented at 10:54 PM on September 7, 2026: member

    ACK 82deb69111f15db60aa364db9b06931918691564

  6. polespinasa commented at 7:35 AM on September 8, 2026: member

    ACK 82deb69111f15db60aa364db9b06931918691564

  7. sedited approved
  8. sedited commented at 8:04 AM on September 8, 2026: contributor

    ACK 82deb69111f15db60aa364db9b06931918691564

  9. sedited merged this on Sep 8, 2026
  10. sedited closed this on Sep 8, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC