refactor: [test] Remove deprecated SetMockTime(i64) alias #36063

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2608-test-time-remove-depr changing 7 files +6 −15

maflcko commented at 10:34 AM on August 24, 2026: member

The deprecated test-only alias is only used in a few places and required in none.

In fact, it is incorrectly used in two unit tests, so first fixup those, and then remove it.

test: refactor: Use FakeNodeClock over manual/global SetMockTime

Using SetMockTime in tests is problematic, because it often requires
verbose calls to
`SetMockTime(GetTime<std::chrono::seconds>() + offset)`.
Also, it requires manual `SetMockTime(0);` at the end.

Fix both issues by using FakeNodeClock.

faf87c3535

util: refactor: Remove deprecated SetMockTime(i64) alias

The deprecated test-only alias is only used in three places and required
in none.

So remove it.

fad1e6bf23

DrahtBot renamed this:
~~refactor: [test] Remove deprecated SetMockTime(i64) alias~~
refactor: [test] Remove deprecated SetMockTime(i64) alias
on Aug 24, 2026
DrahtBot added the label Refactoring on Aug 24, 2026
DrahtBot commented at 10:35 AM on August 24, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36063.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK rustaceanrob

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
rustaceanrob commented at 11:32 AM on August 24, 2026: member

ACK fad1e6bf238ef4693464faf4102934c5b2dc7cb2
fanquake merged this on Aug 24, 2026
fanquake closed this on Aug 24, 2026
maflcko deleted the branch on Aug 24, 2026

Type	Reviewers
ACK	rustaceanrob

Contributors

Labels

refactor: [test] Remove deprecated SetMockTime(i64) alias #36063

Code Coverage & Benchmarks

Reviews