test: cover OP_SUCCESSx bypassing the initial stack element size limit #36044

pull ViniciusCestarii wants to merge 1 commits into bitcoin:master from ViniciusCestarii:test-tapscript-opsuccess-stack-element-limit changing 1 files +1 −0
  1. ViniciusCestarii commented at 4:14 PM on August 20, 2026: contributor

    BIP-342 specifies that the initial stack resource checks happen after OP_SUCCESSx processing, and explicitly notes the checks "can be bypassed using OP_SUCCESSx". Core implements this correctly, but there are currently no tests covering this behavior. This means a consensus-breaking change to the ordering could pass the test suite undetected. Verified this on local commit https://github.com/ViniciusCestarii/bitcoin/commit/68d24d74301fe01ff612535878cb2ae864e8183f, which mutates to incorrectly implement the order and CI still turns green.

    Add a new test at feature_taproot.py to cover OP_SUCCESSx bypassing the initial stack element size limit.

    Verified that the new test catches the mutant: https://github.com/ViniciusCestarii/bitcoin/commit/f8f42a13a8142ac50ee24b33e814d4f4a48ee53d.

  2. test: cover OP_SUCCESSx bypassing the initial stack element size limit 558e26e66e
  3. DrahtBot added the label Tests on Aug 20, 2026
  4. DrahtBot commented at 4:14 PM on August 20, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36044.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK instagibbs

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. ViniciusCestarii marked this as ready for review on Aug 23, 2026
  6. instagibbs commented at 8:48 PM on August 26, 2026: member

    ACK 558e26e66e0256d57f26d4c511dfb41c12efd698

    thanks for the coverage

  7. fanquake merged this on Aug 27, 2026
  8. fanquake closed this on Aug 27, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-09 07:56 UTC