Although these sysctl calls report generic system errors rather than network errors, NetworkErrorString() is identical to SysErrorString() on POSIX systems, so this does not change behavior. It allows removing #include <util/syserror.h>, which was only needed by __APPLE__ code and would otherwise require an #ifdef guard to silence an IWYU unused-include warning on other platforms.
Related to #34995.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35667.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | sedited |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Suggested by @fanquake in #34995 (review).
Although these `sysctl` calls report generic system errors rather
than network errors, `NetworkErrorString()` is identical to
`SysErrorString()` on POSIX systems, so this does not change behavior.
It allows removing `#include <util/syserror.h>`, which was only needed
by `__APPLE__` code and would otherwise require an `#ifdef` guard to
silence an IWYU unused-include warning on other platforms.
ACK eccb04a321acd698dc221b826fe030cb16edd62b