refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>` #35658

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260704-systypes changing 2 files +0 −2

hebasto commented at 4:26 PM on July 4, 2026: member
Pure getifaddrs()/freeifaddrs() calls do not need any type definitions beyond those provided by <ifaddrs.h> itself.

The subsequent struct ifaddrs processing in netif.cpp does not involve any symbols from <sys/types.h>.

Platform-specific manual pages for reviewers' convenience:
Related to #34995.

refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>`

Pure `getifaddrs()`/`freeifaddrs()` calls do not need any type
definitions beyond those provided by `<ifaddrs.h>` itself.

The subsequent `struct ifaddrs` processing in `netif.cpp` does not
involve any symbols from `<sys/types.h>`.

22c328d388

DrahtBot added the label Refactoring on Jul 4, 2026
DrahtBot commented at 4:26 PM on July 4, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35658.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, sedited

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #34995 (iwyu: Fix warnings in src/common and treat them as errors by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
maflcko commented at 9:52 AM on July 6, 2026: member

lgtm ACK 22c328d388a677bea7cc4feb179e154c7ca2f416
in cmake/module/TestAppendRequiredLibraries.cmake:18 in 22c328d388
```
  14 | @@ -15,7 +15,6 @@ function(test_append_socket_library target)
  15 |    endif()
  16 |  
  17 |    set(check_socket_source "
  18 | -    #include <sys/types.h>
```
vicjuma commented at 11:23 AM on July 6, 2026:

ACK. Probably a historical convention on OpenBSD, though it appears to be currently unnecessary as seen in FreeBSD.
sedited approved
sedited commented at 11:53 AM on July 6, 2026: contributor

ACK 22c328d388a677bea7cc4feb179e154c7ca2f416
sedited merged this on Jul 6, 2026
sedited closed this on Jul 6, 2026
hebasto deleted the branch on Jul 6, 2026

Type	Reviewers
ACK	maflcko, sedited

Contributors

Labels

Linked (view graph)

#34995 iwyu: Fix warnings in `src/common` and treat them as errors

refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>` #35658

Code Coverage & Benchmarks

Reviews

Conflicts