fuzz: Remove `ConsumeUniValue` #35653

pull marcofleon wants to merge 1 commits into bitcoin:master from marcofleon:2026/07/ipc-fuzz-followup changing 3 files +2 −14
  1. marcofleon commented at 5:28 PM on July 3, 2026: contributor

    Addresses #35118 (review).

    ConsumeUniValue isn't that useful as a shared fuzz helper, as it just returns the same hard-coded fields. This PR removes it and updates the ipc target to read a UniValue directly from fuzzer input instead. This is similar to what the parse_univalue target already does, and lets ipc test with different JSON values instead of one fixed value.

  2. fuzz: Remove ConsumeUniValue
    The helper created a UniValue with hard-coded constants, which
    isn't ideal for fuzz tests. Replace it in the ipc fuzz test with
    parsing a UniValue directly from the fuzzed data provider.
    9f3e427228
  3. DrahtBot added the label Fuzzing on Jul 3, 2026
  4. DrahtBot commented at 5:28 PM on July 3, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35653.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sedited, brunoerg

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. marcofleon renamed this:
    fuzz: Remove ConsumeUniValue
    fuzz: Remove `ConsumeUniValue`
    on Jul 3, 2026
  6. sedited approved
  7. sedited commented at 5:54 PM on July 3, 2026: contributor

    ACK 9f3e427228007de5a47db1c08a361f90e67288f9

  8. brunoerg approved
  9. brunoerg commented at 5:55 PM on July 3, 2026: contributor

    code review ACK 9f3e427228007de5a47db1c08a361f90e67288f9

  10. sedited merged this on Jul 3, 2026
  11. sedited closed this on Jul 3, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-09 06:47 UTC