doc: Improve offline-signing-tutorial after 32489 #35651

pull pablomartin4btc wants to merge 1 commits into bitcoin:master from pablomartin4btc:doc/32489-tutorial-fixes changing 1 files +2 −4
  1. pablomartin4btc commented at 3:36 PM on July 3, 2026: member

    General improvements noted in the #32489 review and deferred by the author:

    • Remove a stale NOTE referencing walletcreatefundedpsbt; the tutorial was updated to use the send RPC instead.
    • Fix listtransactions example output from {...} to [...]; the RPC returns a JSON array, not an object.
  2. doc: improve offline-signing-tutorial after 32489
    General improvements noted in the #32489 review and deferred by the
    author:
    
    - Remove a stale NOTE referencing walletcreatefundedpsbt; the tutorial
      was updated to use the send RPC instead.
    - Fix listtransactions example output from {...} to [...]; the RPC
      returns a JSON array, not an object.
    68cb7840d2
  3. DrahtBot added the label Docs on Jul 3, 2026
  4. DrahtBot commented at 3:37 PM on July 3, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35651.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK polespinasa

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. pablomartin4btc renamed this:
    doc: improve offline-signing-tutorial after 32489
    doc: Improve offline-signing-tutorial after 32489
    on Jul 3, 2026
  6. DrahtBot added the label CI failed on Jul 3, 2026
  7. DrahtBot removed the label CI failed on Jul 6, 2026
  8. fanquake requested review from polespinasa on Jul 7, 2026
  9. polespinasa approved
  10. polespinasa commented at 2:08 PM on July 7, 2026: member

    ACK 68cb7840d2c98350abf8f018ef6b510c19b5c759

    Thanks for fixing this, didn't realize while updating the doc in the other PR :)

  11. fanquake merged this on Jul 7, 2026
  12. fanquake closed this on Jul 7, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-09 06:47 UTC