This is a follow-up to #32489.
doc: Add release notes for 32489 (exportwatchonlywallet RPC) #35650
pull pablomartin4btc wants to merge 1 commits into bitcoin:master from pablomartin4btc:release-notes/32489 changing 1 files +15 −0-
pablomartin4btc commented at 2:41 PM on July 3, 2026: member
-
doc: Add release notes for 32489 (exportwatchonlywallet RPC) cddbad325d
- DrahtBot added the label Docs on Jul 3, 2026
-
DrahtBot commented at 2:41 PM on July 3, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35650.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK polespinasa If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
in doc/release-notes-32489.md:10 in cddbad325d
5 | +existing descriptor wallet. The exported file contains the wallet's public 6 | +descriptors (with derived key caches where needed), transactions, and address 7 | +book data, but no private keys. It can be imported on another node using the 8 | +existing `restorewallet` RPC. 9 | + 10 | +Wallet
polespinasa commented at 2:42 PM on July 3, 2026:I am not sure if this is Wallet or Doc. Just commenting it so other reviewers who might know it can comment.
in doc/release-notes-32489.md:4 in cddbad325d
0 | @@ -0,0 +1,15 @@ 1 | +New RPCs 2 | +-------- 3 | + 4 | +A new `exportwatchonlywallet` RPC creates a watchonly wallet file from an
polespinasa commented at 2:45 PM on July 3, 2026:I would say
creates a watchonly wallet backup fileto be consistent withrestorewalletdocumentation
pablomartin4btc commented at 3:14 PM on July 3, 2026:You made me think about it but I believe a backup would imply a full copy you can restore from — private keys and all.
exportwatchonlywalletdeliberately omits private keys. Calling it a "backup file" would suggest to users that their private keys are safe inside it, which they're not.The fact that
restorewallethappens to work as the import mechanism is an implementation detail (compatible file format), not a semantic equivalence.Also, if anything, the language to keep consistent with is the
exportwatchonlywalletRPC help text itself, which says "Creates a wallet file at the specified destination containing a watchonly version of the current wallet." The release notes echo that correctly I think. Thank you!
polespinasa commented at 3:21 PM on July 3, 2026:Fair enough :)
in doc/release-notes-32489.md:6 in cddbad325d
0 | @@ -0,0 +1,15 @@ 1 | +New RPCs 2 | +-------- 3 | + 4 | +A new `exportwatchonlywallet` RPC creates a watchonly wallet file from an 5 | +existing descriptor wallet. The exported file contains the wallet's public 6 | +descriptors (with derived key caches where needed), transactions, and address
polespinasa commented at 2:45 PM on July 3, 2026:maybe -> with derived keys and cache if needed
pablomartin4btc commented at 2:53 PM on July 3, 2026:I'd keep it as is. Thanks!
fanquake added this to the milestone 32.0 on Jul 3, 2026polespinasa commented at 3:24 PM on July 3, 2026: memberACK cddbad325d308d60c76afb1d732ff910ae8cda70
fanquake merged this on Jul 6, 2026fanquake closed this on Jul 6, 2026ContributorsLabelsMilestone
32.0
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-09 06:47 UTC