Followup to #35397 (review), which partially reverts changes from #34491.
Also, make sure we install the correct version of lld in OpenBSD job.
depends: move FreeBSD SDK handling to CI #35649
pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:freebsd_partial_revert changing 4 files +38 −27-
fanquake commented at 2:00 PM on July 3, 2026: member
- fanquake requested review from hebasto on Jul 3, 2026
- DrahtBot added the label Build system on Jul 3, 2026
-
DrahtBot commented at 2:00 PM on July 3, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35649.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK willcl-ark If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #35412 (ci: add NetBSD Clang cross job by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake force-pushed on Jul 3, 2026
-
hebasto commented at 6:54 PM on July 4, 2026: member
Commit 8347d351570b8e93f54824498d3de162100f17fb can be dropped in favour of the generalised approach suggested in 56701ff6d5c695d80075075953e20eac5cabff4d.
-
244739db9d
depends: move FreeBSD SDK handling to CI
As pointed out by Hebasto, the approach used in #35397 and #35412 is better, rather than hardcoding flags and putting the SDK handling into depends.
-
ci: FreeBSD 15.1 495f43f7b3
-
22ac4ad949
ci: ensure we use correct lld version in OpenBSD job
If we don't suffix with -${APT_LLVM_V}, then lld-21 will be installed. - fanquake force-pushed on Jul 6, 2026
- fanquake requested review from willcl-ark on Jul 7, 2026
- willcl-ark approved
-
willcl-ark commented at 4:07 PM on July 7, 2026: member
ACK 22ac4ad9496697f5881cb9a990fd0b50849e437e
Keeping the CI-managed SDK, LLVM version and linker setup in CI files (rather than depends) make better sense to me. If depends users need a sysroot they can provide one manually.
- fanquake merged this on Jul 8, 2026
- fanquake closed this on Jul 8, 2026
- fanquake deleted the branch on Jul 8, 2026
