Bump leveldb subtree #35313

fanquake commented at 10:47 AM on May 18, 2026: member

Includes:

Squashed 'src/leveldb/' changes from ab6c84e6f3..c274b50867

c274b50867 Merge bitcoin-core/leveldb-subtree#53: refactor: Delete unused `ScopedHandle:operator=(ScopedHandle&&)`
68740f586f Merge bitcoin-core/leveldb-subtree#59: Fix Clang `-Wconditional-uninitialized` warning
70142e186b Merge bitcoin-core/leveldb-subtree#55: build: Require C++17
d123cf5a83 Effectively, this change
31361bf339 Allow different C/C++ standards when this is used as a subproject.
0711e6d082 Fix Clang `-Wconditional-uninitialized` warning
85665f9547 refactor: Delete unused `ScopedHandle:operator=(ScopedHandle&&)`

git-subtree-dir: src/leveldb
git-subtree-split: c274b508676d31a38345d7878550ef3422434b65

6230eca47d

Update leveldb subtree to latest master 8d9aecde51

DrahtBot commented at 10:48 AM on May 18, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35313.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31507 (build: Use clang-cl to build on Windows natively by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto commented at 11:21 AM on May 18, 2026: member

Includes: ...

Fix Clang -Wconditional-uninitialized warning bitcoin-core/leveldb-subtree#59

That PR states that it:

... eliminates the need for the following code:

else()
  try_append_cxx_flags("-Wconditional-uninitialized" TARGET nowarn_leveldb_interface SKIP_LINK
    IF_CHECK_PASSED "-Wno-conditional-uninitialized"
  )

Should we remove this in an additional commit here?

build: remove -Wno-conditional-uninitialized from leveldb build ba04c6bdde

fanquake commented at 1:16 PM on May 18, 2026: member

Should we remove this in an additional commit here?

Pushed that up.

hebasto commented at 1:55 PM on May 18, 2026: member

My Guix build:

aarch64
5b08dc5df82660678e906e5f9df18be6243a671ff2de53d6493e20893b400f1c  guix-build-ba04c6bdde52/output/aarch64-linux-gnu/SHA256SUMS.part
96adeb918d790632473e9f53efda9b374d632fa2e5d297fbf14982871d66f785  guix-build-ba04c6bdde52/output/aarch64-linux-gnu/bitcoin-ba04c6bdde52-aarch64-linux-gnu-debug.tar.gz
eecc49c51124e742a8ed9abf726d505a23c95aee622f996c83a5bf8bb781d32d  guix-build-ba04c6bdde52/output/aarch64-linux-gnu/bitcoin-ba04c6bdde52-aarch64-linux-gnu.tar.gz
26f210416e232e167501bcbf24869b7973c5c7dd3e9be1306031d0ebab8bca99  guix-build-ba04c6bdde52/output/arm-linux-gnueabihf/SHA256SUMS.part
9cafbb682df4bdef48cb2d2eb31d881055ef4dad30d8988bd1205e68b18cf0a9  guix-build-ba04c6bdde52/output/arm-linux-gnueabihf/bitcoin-ba04c6bdde52-arm-linux-gnueabihf-debug.tar.gz
f19d165f1bc2ce7885dd2df913b71bb5986b57d0021c19f4b7d0c2d97e78316d  guix-build-ba04c6bdde52/output/arm-linux-gnueabihf/bitcoin-ba04c6bdde52-arm-linux-gnueabihf.tar.gz
8777c87f9910f1c00baac7102b94fb9f8fcbe0d08a6920fb48d84af4f28f1761  guix-build-ba04c6bdde52/output/arm64-apple-darwin/SHA256SUMS.part
9d5e2f977a3f86189533570089332bfd4b70265dbfeeacde366bcab4456b414f  guix-build-ba04c6bdde52/output/arm64-apple-darwin/bitcoin-ba04c6bdde52-arm64-apple-darwin-codesigning.tar.gz
58bfa7b5b7cf374a1433b31cccc09acc27ec36a22e5a6ed634fced6f65b71306  guix-build-ba04c6bdde52/output/arm64-apple-darwin/bitcoin-ba04c6bdde52-arm64-apple-darwin-unsigned.tar.gz
823c990a98a964fca598c35547b0a633ca339a90d2f0beb3a0af740ae5b62919  guix-build-ba04c6bdde52/output/arm64-apple-darwin/bitcoin-ba04c6bdde52-arm64-apple-darwin-unsigned.zip
3f472e1c90b969d44edc6d5b02b3928f067497c2a65232aed8fde411f3fb68e7  guix-build-ba04c6bdde52/output/dist-archive/bitcoin-ba04c6bdde52.tar.gz
e368ae542f8c4aaed29aee66eb8ec04a23dd724bb1fbe78973824d07d9f981a6  guix-build-ba04c6bdde52/output/powerpc64-linux-gnu/SHA256SUMS.part
f0ca26ae00fdc14e5fb690afce820eca3906ad1cf26a45821540ff6133f63673  guix-build-ba04c6bdde52/output/powerpc64-linux-gnu/bitcoin-ba04c6bdde52-powerpc64-linux-gnu-debug.tar.gz
71aa0843540a4bcc1149f7206fb1b74dc0e1bc22f9edf5d3b109ce300b1e112e  guix-build-ba04c6bdde52/output/powerpc64-linux-gnu/bitcoin-ba04c6bdde52-powerpc64-linux-gnu.tar.gz
f36cca8bccb09cb5adf0148fa50e0f26d44737d04cefd3baeed298ee3ee06812  guix-build-ba04c6bdde52/output/riscv64-linux-gnu/SHA256SUMS.part
21bbbe0f847c353f7ac69ef9f4fc1f2336c4c463212be95bc6ee2884e779fc5e  guix-build-ba04c6bdde52/output/riscv64-linux-gnu/bitcoin-ba04c6bdde52-riscv64-linux-gnu-debug.tar.gz
d43bd8d3af7ab1b449022d5ed0db750de1c672299c48f830fe70770dabf3b5f7  guix-build-ba04c6bdde52/output/riscv64-linux-gnu/bitcoin-ba04c6bdde52-riscv64-linux-gnu.tar.gz
23bb1855a6ba2c55b8e5b7ab91a5b731387a9a8107703941f8f9eab72cfe2eb9  guix-build-ba04c6bdde52/output/x86_64-apple-darwin/SHA256SUMS.part
a96522e189bb3273868b679e16629fc05d4f1abd1da40ee55604ed38157f48ab  guix-build-ba04c6bdde52/output/x86_64-apple-darwin/bitcoin-ba04c6bdde52-x86_64-apple-darwin-codesigning.tar.gz
0d02023e73bc646e78bd7a2966d20e314aeaf0368474fad37bc18ccc064eb402  guix-build-ba04c6bdde52/output/x86_64-apple-darwin/bitcoin-ba04c6bdde52-x86_64-apple-darwin-unsigned.tar.gz
579a6c3cfccae1badee06492a6b3b8978d1d4ca633860e3eba2b23e0235d649e  guix-build-ba04c6bdde52/output/x86_64-apple-darwin/bitcoin-ba04c6bdde52-x86_64-apple-darwin-unsigned.zip
76bcb28ed84bff3dbe4344fe6b6235e5d13e2f11fd2f63f78b0f0faf09b4db67  guix-build-ba04c6bdde52/output/x86_64-linux-gnu/SHA256SUMS.part
628760a87b7c4eee6394b82434af4eefebb6a7123c4c28d7ef1e29d10b8d5bb4  guix-build-ba04c6bdde52/output/x86_64-linux-gnu/bitcoin-ba04c6bdde52-x86_64-linux-gnu-debug.tar.gz
13db5f76c8765d97af2e4fb47d1995808ad19bf62e70676c172569b1c53a7d41  guix-build-ba04c6bdde52/output/x86_64-linux-gnu/bitcoin-ba04c6bdde52-x86_64-linux-gnu.tar.gz
fea444d52ac232cd79e086aa8557d67af776d6d35f78acbc8615ade54229d387  guix-build-ba04c6bdde52/output/x86_64-w64-mingw32/SHA256SUMS.part
ae6c6626b882d9400056266a587ed129605e66d15b0880b9a514eccb8c5830a6  guix-build-ba04c6bdde52/output/x86_64-w64-mingw32/bitcoin-ba04c6bdde52-win64-codesigning.tar.gz
0c8bbcc6f4b7cf0e3c866232eee15c928dd79e4f57eba84aefaef3fb08562498  guix-build-ba04c6bdde52/output/x86_64-w64-mingw32/bitcoin-ba04c6bdde52-win64-debug.zip
8b627d7008d88d198c15024a2f23a4816fda5f271146545fd77bc945d0b8b7d7  guix-build-ba04c6bdde52/output/x86_64-w64-mingw32/bitcoin-ba04c6bdde52-win64-setup-unsigned.exe
0e85fe9d6093752175ed89d32dedbf6d046338d3f9070e854e565abc671f6b96  guix-build-ba04c6bdde52/output/x86_64-w64-mingw32/bitcoin-ba04c6bdde52-win64-unsigned.zip

hebasto approved

hebasto commented at 1:56 PM on May 18, 2026: member

ACK ba04c6bdde5253e531d856497598d5663f822b85.