doc: Fix broken links in dev notes, move sections #35296

pull maflcko wants to merge 5 commits into bitcoin:master from maflcko:2605-doc-fix-links changing 1 files +40 −33

maflcko commented at 7:24 AM on May 15, 2026: member

The anchors in isocpp links were recently broken, so fix them to point to the correct anchor.

Also, move/regroup 3 sections while touching the file.
DrahtBot added the label Docs on May 15, 2026
DrahtBot commented at 7:24 AM on May 15, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35296.



Reviews

See the guideline for information on the review process.

Type Reviewers

Stale ACK janb84

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #35260 (doc: clarify test placement guidance by l0rinc)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label CI failed on May 15, 2026
DrahtBot removed the label CI failed on May 15, 2026
janb84 commented at 1:06 PM on May 15, 2026: contributor

ACK fab42cf626d1fe28f43054e3ea15c35784d5b94f

I have validated that the fixed links indeed work (on both safari and chromium). Also validated that there aren't any leftover broken links in the doc, regarding C++ core guidelines. The reordering of the document seems logical to me, LGTM.
doc: Fix to use lower-case anchors in links to C++ Core Guidelines fa9c2ddea9

Type	Reviewers
Stale ACK	janb84

doc: Regroup clang-tidy rules

* Remove the explicit modernize-use-nullptr rule mention, which has not been needed for years.
* Encourage devs to refer to the upstream clang-tidy rules documentation.
* Move NOLINTNEXTLINE(misc-no-recursion) into a subsection under the new clang-tidy section.

fa37606c65

doc: move-only Python section

Doxygen is about the C++ comment style, so move the Python section to have all C++ style sections in one flow.

fa0202f31d

doc: move-only Valgrind section

Valgrind is often used as a sanitizer, so move it closer to the Sanitizer section.

fa514caad7

doc: Move mutex and thread section into guideline section

Previously, they have been in the "Tips and tricks" section, which seems a bit off.

faf6afd99d