wallet: report importdescriptors timestamp errors per item #35272

pull ferminquant wants to merge 1 commits into bitcoin:master from ferminquant:wallet/importdescriptors-timestamp-errors changing 2 files +71 −8
  1. ferminquant commented at 2:31 PM on May 12, 2026: none

    Fixes #35181.

    Missing or invalid timestamp values in importdescriptors now return an error in the matching result entry instead of aborting the whole RPC. Valid entries in the same batch can still be imported.

    Tests:

    • ninja -C build bitcoind bitcoin-cli test_bitcoin
    • test/functional/wallet_importdescriptors.py --configfile=$PWD/build/test/config.ini
    • build/bin/test_bitcoin -t wallet_rpc_tests
    • python3 -m py_compile test/functional/wallet_importdescriptors.py
    • git diff --check
  2. wallet: report importdescriptors timestamp errors per item 519b4a9f66
  3. DrahtBot added the label Wallet on May 12, 2026
  4. DrahtBot commented at 2:31 PM on May 12, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35272.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK polespinasa

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. polespinasa commented at 2:45 PM on May 12, 2026: member

    NACK

    There has been three PRs in the lasts days addressing the same issue. This comment applies here too: #35185 (comment)

  6. maflcko closed this on May 12, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:51 UTC