[31.x] Backports #35231

1. 
   fanquake commented at 9:21 AM on May 7, 2026: member

   Backports

   • #34228
   • #34991
   • #35044
   • #35218
   • #35227
   • #35230
   • #35283
   • #35289
2. fanquake added this to the milestone 31.1 on May 7, 2026
3. DrahtBot added the label Backport on May 7, 2026
4. 
   DrahtBot commented at 9:22 AM on May 7, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35231.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. fanquake force-pushed on May 7, 2026
6. DrahtBot added the label CI failed on May 7, 2026
7. test: fix send_batch_request to pass callables when using --usecli

   send_batch_request() was building raw dicts without a "jsonrpc" version, which made Core to treat them as version 1.0 requests.
   This worked in normal mode, but failed with --usecli because TestNodeCLI.batch() expects callables, not dicts.
   
   This commit fixes it by using get_request() which is defined in both AuthServiceProxy and TestNodeCLIAttr.
   The assert is changed because by using get_reques() AuthServiceProxy treats it as "jsonrpc" version 2.0 requests, which don't return "error" keys.
   
   Github-Pull: #34991
   Rebased-From: 5603ae0ffa3f0be3d22e8a09008e46c5d48ae12f

   9d42e868fe
8. ci: add --extended when using --usecli

   Add the flag --extended to a test (00_setup_env_i686_no_ipc.sh) with the --usecli flag to cover all tests with --usecli.
   
   Github-Pull: #34991
   Rebased-From: a49bc1e24e69ac43beecbdc9c39da3d02160034e

   56190e5c5c
9. fanquake force-pushed on May 7, 2026
10. DrahtBot removed the label CI failed on May 7, 2026
11. depends: Unset `SOURCE_DATE_EPOCH` in `gen_id` script

    Github-Pull: #34228
    Rebased-From: 9f7a2293c48f8afb5e87765a327a0c89fd21fa56

    64ba4e2a3b
12. fanquake force-pushed on May 8, 2026
13. ci: Move --usecli --extended from i386 task to alpine task

    Github-Pull: #35230
    Rebased-From: fad61896e869fe004cb1ebdacbd124ce587e6efc

    313a225fef
14. test: fix P2SH output in coins cache fuzz

    The `coinscache_sim` fuzz target builds a 23-byte P2SH scriptPubKey manually.
    Place `OP_EQUAL` at index 22, after `OP_HASH160`, the 20-byte push opcode, and the 20-byte script hash.
    This matches `CScript::IsPayToScriptHash()`, which checks byte 22 for `OP_EQUAL`, see src/script/script.cpp#L229
    
    Github-Pull: #35218
    Rebased-From: ac58e6c53c262e08584cb809daf3fbc8dd4d3732

    5022e9d411
15. fanquake force-pushed on May 8, 2026
16. wallet: check BDB last page LSN

    The BDB metadata field `last_page` stores the last valid page number, not the number of pages.
    The read-only wallet migration parser currently checks reset LSNs with a half-open loop, so it skips the final page and may accept a database whose last page still depends on BDB log files.
    
    Github-Pull: #35227
    Rebased-From: e2b0984f99519f76423ce26ce9077ca765b2b30b

    409b2d8475
17. fanquake force-pushed on May 11, 2026
18. doc: mention -DWITH_ZMQ=ON in BSD build guides

    The FreeBSD, NetBSD, and OpenBSD build guides state that ZMQ support is compiled in when the package is installed. Since WITH_ZMQ defaults to OFF, update the wording to mention the required CMake option.
    
    Github-Pull: #35283
    Rebased-From: ca93ab808c488324990eb91ed8297a37dd10d580

    e379148a7a
19. fanquake force-pushed on May 14, 2026
20. fuzz: Fix txorphan timeout by limiting block weight

    Github-Pull: #35289
    Rebased-From: 004a7e3cfbc5b2118536651d2201cf8b72c87736

    7a97580997
21. fanquake force-pushed on May 14, 2026
22. contrib: Fix NameError in signet miner gbt()

    The logging.warning call referenced `bci["bestblockhash"]`, a variable
    from the calling scope `do_generate()` that is not available inside the
    `Generate.gbt()` method. This would crash with a NameError when
    getblocktemplate returned a template based on an unexpected previous
    block.
    
    Use the `bestblockhash` parameter that was already being passed in and
    used correctly in the comparison on the line above.
    
    The bug was introduced in 7b31332370 when the gbt logic was extracted
    into its own method — the if-condition was updated but the logging
    call was not.
    
    Github-Pull: #35044
    Rebased-From: 701bc2dc02f73a10498ecf70c5d3523e0bb6b953

    0449061877
23. doc: update release notes for v31.x 506051cc60
24. fanquake force-pushed on May 15, 2026

Milestone
31.1