move-only: hide coins cache internals #35180

pull l0rinc wants to merge 3 commits into bitcoin:master from l0rinc:l0rinc/hide-coins-cache-helpers changing 1 files +29 −31

l0rinc commented at 8:49 AM on April 30, 2026: contributor

Problem

CCoinsViewCache exposes a few implementation details that are only used to maintain its own cache state. This makes the public interface broader than necessary, and leaves the class declaration split across repeated access sections.

Fix

Group the internal declarations in the default-private part of CCoinsViewCache, then move ReallocateCache() and ResetGuard out of the public interface.

CreateResetGuard() remains public, so callers can still request scoped reset behavior without naming or constructing the guard type directly. Reset() remains protected for subclass-facing reset hooks.

coins: group private cache declarations

Move the private `FetchCoin()` declaration next to the default-private `CCoinsViewCache` members and rely on `class` default access for `m_deterministic`.
This prepares the class layout for narrower helper visibility without leaving a trailing `private:` section.

db4f8ef633

coins: hide cache reallocation helper

Move `ReallocateCache()` out of the public `CCoinsViewCache` interface.
It is only called internally by `Flush()` when the cache map should release memory after clearing entries.

08d669cc4e

coins: hide cache reset guard

Move `ResetGuard` out of the public `CCoinsViewCache` interface.
Callers can still request scoped resets through `CreateResetGuard()` without naming the guard type directly.

Leave `Reset()` protected as part of the subclass-facing reset hook surface.

06040b4189

DrahtBot added the label Refactoring on Apr 30, 2026
DrahtBot commented at 8:49 AM on April 30, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35180.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK optout21

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #34132 (coins: drop error catcher, centralize fatal read handling by l0rinc)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
optout21 commented at 1:35 PM on April 30, 2026: contributor

Concept ACK 06040b4189a0db9c43c5570e62b9292e609c247e

Type	Reviewers
ACK	optout21

in src/coins.h:395 in db4f8ef633

 391 | @@ -392,9 +392,14 @@ class CCoinsViewBacked : public CCoinsView
 392 |  /** CCoinsView that adds a memory cache for transactions to another CCoinsView */
 393 |  class CCoinsViewCache : public CCoinsViewBacked
 394 |  {
 395 | -private:

optout21 commented at 2:20 PM on May 5, 2026:

db4f8ef coins: group private cache declarations:

I'd prefer keeping the explicit private, even though it's unnecessary

optout21 commented at 2:23 PM on May 5, 2026: contributor

ACK 06040b4189a0db9c43c5570e62b9292e609c247e

A minor, move-only refactor to reduce visibility of some CCoinsViewCache members.

Contributors

Labels

Linked (view graph)

#31132 validation: fetch block inputs on parallel threads #34280 Coins Cache Cleanup checklist

move-only: hide coins cache internals #35180

Problem

Fix

Code Coverage & Benchmarks

Reviews

Conflicts