depends: Boost 1.91.0-1 #35147

https://www.boost.org/releases/1.91.0/.

MultiIndex

Breaking change: All type lists accepted or provided by the library (indexed_by, tag, nested typedefs index_specifier_type_list, index_type_list, iterator_type_list and const_iterator_type_list) are no longer based on Boost.MPL but instead they are now Boost.Mp11 lists. As a result, Boost.MultiIndex doesn’t depend anymore on Boost.MPL. It is expected that most user code won’t be impacted by this change, but the previous behavior may be restored, however, by globally defining the macro BOOST_MULTI_INDEX_ENABLE_MPL_SUPPORT. Legacy support for Boost.MPL may be eventually deprecated and removed in the future.

Breaking change: composite_key and associated class templates (composite_key_equal_to, composite_key_compare, composite_key_hash) have been made variadic (previously the maximum number of template arguments was limited by BOOST_MULTI_INDEX_LIMIT_COMPOSITE_KEY_SIZE). This change should be transparent to users, with the exception that composite_key::key_extractors returns a std::tuple instead of a boost::tuple (and similarly for the rest of affected class templates).

Removed internal workarounds and fallbacks to support pre-C++11 compilers.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35147.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

<!--85328a0da195eb286784d51f73fa0af9-->

🚧 At least one of the CI tasks failed. _{Task 32 bit ARM: https://github.com/bitcoin/bitcoin/actions/runs/24869904274/job/72813921619} _{LLM reason (✨ experimental): CI failed at build time due to C++ compilation errors in src/txmempool.h (Boost multi_index get<index_by_wtxid> template misuse and missing m_entry_vec symbol).}

<details><summary>Hints</summary>

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

• Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

• A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

• An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

</details>

<strike>I think you forgot to copy the required headers? The update should be transparent. At least it seems to be passing in https://github.com/hebasto/bitcoin-core-nightly/actions/runs/24873579092/job/72825220909#step:3:49 , but maybe I am missing something?

I think you forgot to copy the required headers? The update should be transparent. At least it seems to be passing in https://github.com/hebasto/bitcoin-core-nightly/actions/runs/24873579092/job/72825220909#step:3:49 , but maybe I am missing something?

That CI job is still using Boost 1.90.

https://www.boost.org/releases/1.91.0/.

MultiIndex

Breaking change: All type lists accepted or provided by the library (indexed_by, tag, nested typedefs index_specifier_type_list, index_type_list, iterator_type_list and const_iterator_type_list) are no longer based on Boost.MPL but instead they are now Boost.Mp11 lists. As a result, Boost.MultiIndex doesn’t depend anymore on Boost.MPL. It is expected that most user code won’t be impacted by this change, but the previous behavior may be restored, however, by globally defining the macro BOOST_MULTI_INDEX_ENABLE_MPL_SUPPORT. Legacy support for Boost.MPL may be eventually deprecated and removed in the future.

Breaking change: composite_key and associated class templates (composite_key_equal_to, composite_key_compare, composite_key_hash) have been made variadic (previously the maximum number of template arguments was limited by BOOST_MULTI_INDEX_LIMIT_COMPOSITE_KEY_SIZE). This change should be transparent to users, with the exception that composite_key::key_extractors returns a std::tuple instead of a boost::tuple (and similarly for the rest of affected class templates).

Removed internal workarounds and fallbacks to support pre-C++11 compilers.

Globally defining the BOOST_MULTI_INDEX_ENABLE_MPL_SUPPORT macro seems not working as expected.

Update: See here and here.

My Guix build:

aarch64
e14133a8f8e69b5aa6c1b9fa18c3d42bfd9f4de86174d1a306c2a515fc539899  guix-build-90255c242cc4/output/aarch64-linux-gnu/SHA256SUMS.part
2e73333d9e14aeb0ff0cd048ed4a0c228854d8c565b914add64feecdeaaf495d  guix-build-90255c242cc4/output/aarch64-linux-gnu/bitcoin-90255c242cc4-aarch64-linux-gnu-debug.tar.gz
19b11b83835d5c40b0b8210e811848157163c840c1a7c3d5d73ebfdc69d95040  guix-build-90255c242cc4/output/aarch64-linux-gnu/bitcoin-90255c242cc4-aarch64-linux-gnu.tar.gz
10d8006e040e9540015498595b64b809ac57d9406d34eb5cb4662932e2982256  guix-build-90255c242cc4/output/arm-linux-gnueabihf/SHA256SUMS.part
d95ae6abd8196f3cef9a61446f9c1db30de45e435ab1af5239f9a6b64f76f731  guix-build-90255c242cc4/output/arm-linux-gnueabihf/bitcoin-90255c242cc4-arm-linux-gnueabihf-debug.tar.gz
946e46e8937edcef8964d6cdb0d578a706805e377b272737c1df3b8423f8c815  guix-build-90255c242cc4/output/arm-linux-gnueabihf/bitcoin-90255c242cc4-arm-linux-gnueabihf.tar.gz
fbf1437486065ef8d691303e134fbe3d86ab6df7ec142182c251728d3986d626  guix-build-90255c242cc4/output/arm64-apple-darwin/SHA256SUMS.part
852bda463f57e790493afcc3d42c6d4be7ab4541deede8856e40c4e13671546a  guix-build-90255c242cc4/output/arm64-apple-darwin/bitcoin-90255c242cc4-arm64-apple-darwin-codesigning.tar.gz
d98454d0324b638d76b755f0d4b33f130f25df6ff552e75e6db79759435c67ef  guix-build-90255c242cc4/output/arm64-apple-darwin/bitcoin-90255c242cc4-arm64-apple-darwin-unsigned.tar.gz
a49f27abc5a21a4871d560aa52643bc01de3547afa7f76c64f890b97e3a58daa  guix-build-90255c242cc4/output/arm64-apple-darwin/bitcoin-90255c242cc4-arm64-apple-darwin-unsigned.zip
e1a6957ad341437f8655f8e4d9a08d9ab61d57a34b3f764f30b3cffcae2958f8  guix-build-90255c242cc4/output/dist-archive/bitcoin-90255c242cc4.tar.gz
57ef42a9f442114eb48fe993a50768f2c133183da8c53d26effbdf94c7abb2a9  guix-build-90255c242cc4/output/powerpc64-linux-gnu/SHA256SUMS.part
bfaa40d6248d7c09bb029800426469909575eb0f8045a80f351d0be1033b8a14  guix-build-90255c242cc4/output/powerpc64-linux-gnu/bitcoin-90255c242cc4-powerpc64-linux-gnu-debug.tar.gz
a0ca0fbb67cf91900644da7b289e83c45d96c2b928a601f7921509c708d1b7f2  guix-build-90255c242cc4/output/powerpc64-linux-gnu/bitcoin-90255c242cc4-powerpc64-linux-gnu.tar.gz
131432ee35155bba0fd94e9bba097c809b7bb0e37e374790ac657c6d50fe1e12  guix-build-90255c242cc4/output/riscv64-linux-gnu/SHA256SUMS.part
7d9d9748641d29b773e635f411c2b48f3156fbdc5cd1309d9c6d95efb68d9780  guix-build-90255c242cc4/output/riscv64-linux-gnu/bitcoin-90255c242cc4-riscv64-linux-gnu-debug.tar.gz
e1ee27fe2c48dc9c1d16eb44434f7a4c2432f448289cd75f9ef0ea8e4d853be2  guix-build-90255c242cc4/output/riscv64-linux-gnu/bitcoin-90255c242cc4-riscv64-linux-gnu.tar.gz
49c97094b0ff27ab6332062f5cc409af82f6ef29f79948d3156b92d224c16b0d  guix-build-90255c242cc4/output/x86_64-apple-darwin/SHA256SUMS.part
892f6d959cfcba5d409a9333717a2a8f411bb07f1639bd188773b9d41d206e61  guix-build-90255c242cc4/output/x86_64-apple-darwin/bitcoin-90255c242cc4-x86_64-apple-darwin-codesigning.tar.gz
0521807c683a37445eae04fdfefa798d9debbb47d4abe1545601944a06101979  guix-build-90255c242cc4/output/x86_64-apple-darwin/bitcoin-90255c242cc4-x86_64-apple-darwin-unsigned.tar.gz
c0363a3aa3b097951055ce1e5f5b7383b16ea9dd9e5d04ac63677f91dd04e62e  guix-build-90255c242cc4/output/x86_64-apple-darwin/bitcoin-90255c242cc4-x86_64-apple-darwin-unsigned.zip
f5ae0f3801d619966a48948d97ba980772dfd75b011cd14f455fac70616f9d45  guix-build-90255c242cc4/output/x86_64-linux-gnu/SHA256SUMS.part
f135d6cdafb07b2117cb7194dcb4c6fe046fb5b433b3187b6da75501fbf279ab  guix-build-90255c242cc4/output/x86_64-linux-gnu/bitcoin-90255c242cc4-x86_64-linux-gnu-debug.tar.gz
9a36f9ca51c0e34e1158887423e90576557c2ddcf8ceb3bc609f17d85f2b885b  guix-build-90255c242cc4/output/x86_64-linux-gnu/bitcoin-90255c242cc4-x86_64-linux-gnu.tar.gz
ab2a5de56f35c91fca97e04f8ccbc96b9afaa4cc4b4e481ac7b76f921f65c5ec  guix-build-90255c242cc4/output/x86_64-w64-mingw32/SHA256SUMS.part
b3c6cf1b9db52141f8c54be2f95beedb24efdf7374f994a9e15d3e0afbe864f0  guix-build-90255c242cc4/output/x86_64-w64-mingw32/bitcoin-90255c242cc4-win64-codesigning.tar.gz
421e3909746a2ae9abebafd27527cc61d2fb1d0492a553f1dc94b0471dac7bd6  guix-build-90255c242cc4/output/x86_64-w64-mingw32/bitcoin-90255c242cc4-win64-debug.zip
aa90ef109c599d2d74f99f5a66c6a10347931808749eedacfb12212c2cb3195c  guix-build-90255c242cc4/output/x86_64-w64-mingw32/bitcoin-90255c242cc4-win64-setup-unsigned.exe
4a04b0d9e0623d76d672307d50eac20d67e1db55610fa8cff0b51a33aec589f5  guix-build-90255c242cc4/output/x86_64-w64-mingw32/bitcoin-90255c242cc4-win64-unsigned.zip

According to Corecheck (https://corecheck.dev/bitcoin/bitcoin/pulls/35147), this may result in a ~10% speedup in the OrphanageEraseForPeer benchmark.

But corecheck doesn't use depends, does it?

I thought it was doing depends build at some point, maybe not longer, and this is just noise.

But corecheck doesn't use depends, does it?

It does not. This is just noise I'm afraid. Corecheck will hide anything that has less than 10% variance and that single benchmark just edged over.

ACK f12f8c4d7393b139aea3b4253aa966230ee0032e.